Skip to content

Fix Linux sandbox startup with multiple denied files - #50059

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/85158c83699afd36bb7aca453b2652d777cf65e4
Oct 1, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/85158c83699afd36bb7aca453b2652d777cf65e4

Conversation

@copyberry

@copyberry copyberry Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Fix Linux sandbox startup with multiple denied files

Why

Bubblewrap consumes and closes the file descriptor for each --ro-bind-data mount. Reusing one descriptor across multiple file masks prevents the sandbox from starting.

What changed

Open and preserve a separate /dev/null descriptor for each empty-file mask.

Testing

Extend unit tests to verify distinct descriptors for multiple denied files and missing-path masks. Add integration coverage for exact-path and glob deny rules, checking that the sandbox starts, denied files remain unreadable and unwritable, and allowed files remain accessible.

## Why

Bubblewrap consumes and closes the file descriptor for each `--ro-bind-data` mount. Reusing one descriptor across multiple file masks prevents the sandbox from starting.

## What changed

Open and preserve a separate `/dev/null` descriptor for each empty-file mask.

## Testing

Extend unit tests to verify distinct descriptors for multiple denied files and missing-path masks. Add integration coverage for exact-path and glob deny rules, checking that the sandbox starts, denied files remain unreadable and unwritable, and allowed files remain accessible.

GitOrigin-RevId: 85158c83699afd36bb7aca453b2652d777cf65e4
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/85158c83699afd36bb7aca453b2652d777cf65e4 branch from d73e276 to ae7aad5 Compare October 1, 2026 18:05
@copyberry
copyberry Bot merged commit ae7aad5 into main Oct 1, 2026
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/85158c83699afd36bb7aca453b2652d777cf65e4 branch October 1, 2026 18:05
@leyla86-cpu
leyla86-cpu deployed to issue-triage October 1, 2026 18:06 — with GitHub Actions Active
@leyla86-cpu
leyla86-cpu deployed to issue-triage October 1, 2026 18:06 — with GitHub Actions Active
@leyla86-cpu
leyla86-cpu deployed to issue-triage October 1, 2026 18:06 — with GitHub Actions Active
@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@github-actions github-actions Bot locked and limited conversation to collaborators Oct 1, 2026
@thepowerceo
thepowerceo deployed to issue-triage October 1, 2026 18:26 — with GitHub Actions Active
@thepowerceo
thepowerceo deployed to issue-triage October 1, 2026 18:26 — with GitHub Actions Active
@thepowerceo
thepowerceo deployed to issue-triage October 1, 2026 18:26 — with GitHub Actions Active
@demon1818
demon1818 deployed to issue-triage October 1, 2026 18:27 — with GitHub Actions Active
@demon1818
demon1818 deployed to issue-triage October 1, 2026 18:27 — with GitHub Actions Active
@demon1818
demon1818 deployed to issue-triage October 1, 2026 18:27 — with GitHub Actions Active
@thepowerceo
thepowerceo deployed to issue-triage October 1, 2026 18:29 — with GitHub Actions Active

This branch was successfully deployed

1 active deployment
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants