Repository navigation
Launch Windows daemon children in a dedicated working directory - #49850
Merged
copyberry[bot] merged 1 commit intoOct 1, 2026
Conversation
## Why Windows processes hold their working directory open for their lifetime, and sandbox setup may broaden its ACL. Managed children should avoid pinning the launching project's directory or changing permissions on the private daemon state directory. ## What changed Create a `workdir` subdirectory alongside the PID files and use it as the working directory for both the managed app-server and updater on Windows. ## Testing Add a Windows regression test covering both managed children. It verifies that relative files land in `workdir`, the state directory still passes private-directory validation, and stopping each child removes its PID file. GitOrigin-RevId: 12ca95463ff3c80899a5b1a8800fead849f48017
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/12ca95463ff3c80899a5b1a8800fead849f48017
branch
from
October 1, 2026 03:57
103dc79 to
e2a7d53
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/12ca95463ff3c80899a5b1a8800fead849f48017
branch
October 1, 2026 03:57
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Launch Windows daemon children in a dedicated working directory
Why
Windows processes hold their working directory open for their lifetime, and sandbox setup may broaden its ACL. Managed children should avoid pinning the launching project's directory or changing permissions on the private daemon state directory.
What changed
Create a
workdirsubdirectory alongside the PID files and use it as the working directory for both the managed app-server and updater on Windows.Testing
Add a Windows regression test covering both managed children. It verifies that relative files land in
workdir, the state directory still passes private-directory validation, and stopping each child removes its PID file.