Skip to content

Define exec-server protocol types for streamed file writes - #49778

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/4d3997717e821cd1f62df12a03c8eec36332a66d
Oct 1, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/4d3997717e821cd1f62df12a03c8eec36332a66d

Conversation

@copyberry

@copyberry copyberry Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Define exec-server protocol types for streamed file writes

What changed

  • Add read and replace modes to fs/open, defaulting omitted modes to read for existing callers.
  • Define fs/writeBlock request and response types for offset-based writes, with a maximum decoded chunk size of 1 MiB.
  • Add the fileWriteStreaming capability, defaulting to false. Keep writable streams unsupported in the server and explicitly reject replacement opens.

Testing

Add a protocol test verifying that legacy fs/open requests without a mode deserialize as read-only opens.

## What changed

- Add `read` and `replace` modes to `fs/open`, defaulting omitted modes to `read` for existing callers.
- Define `fs/writeBlock` request and response types for offset-based writes, with a maximum decoded chunk size of 1 MiB.
- Add the `fileWriteStreaming` capability, defaulting to `false`. Keep writable streams unsupported in the server and explicitly reject replacement opens.

## Testing

Add a protocol test verifying that legacy `fs/open` requests without a mode deserialize as read-only opens.

GitOrigin-RevId: 4d3997717e821cd1f62df12a03c8eec36332a66d
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/4d3997717e821cd1f62df12a03c8eec36332a66d branch from 0503c4c to 875bf92 Compare October 1, 2026 00:44
@copyberry
copyberry Bot merged commit 875bf92 into main Oct 1, 2026
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/4d3997717e821cd1f62df12a03c8eec36332a66d branch October 1, 2026 00:44
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 1, 2026
@smileBeda
smileBeda deployed to issue-triage October 1, 2026 00:44 — with GitHub Actions Active
@smileBeda
smileBeda deployed to issue-triage October 1, 2026 00:44 — with GitHub Actions Active
@smileBeda
smileBeda deployed to issue-triage October 1, 2026 00:44 — with GitHub Actions Active
@smileBeda
smileBeda deployed to issue-triage October 1, 2026 00:45 — with GitHub Actions Active
@smileBeda
smileBeda deployed to issue-triage October 1, 2026 00:47 — with GitHub Actions Active
@smileBeda
smileBeda deployed to issue-triage October 1, 2026 00:47 — with GitHub Actions Active
@smileBeda
smileBeda deployed to issue-triage October 1, 2026 00:47 — with GitHub Actions Active

This branch was successfully deployed

1 active deployment
issue-triage — 875bf920 Deployed Oct 1, 2026 by smileBeda via Identify potential duplicates (all issues) #50357
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants