Skip to content

Upgrade the argument comment lint toolchain and Dylint - #49706

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/34e1b173972f0bfa9b6c8fd3342ca652539efe2f
Sep 30, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/34e1b173972f0bfa9b6c8fd3342ca652539efe2f

Conversation

@copyberry

@copyberry copyberry Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Upgrade the argument comment lint toolchain and Dylint

What changed

  • Move the lint to nightly-2026-08-20 and Dylint 6.1.0, updating CI, release artifacts, Bazel configuration, and installation instructions.
  • Adapt to the updated rustc and Clippy APIs, including resolving Option::None through type aliases when checking for uncommented arguments.
  • Set the chatgpt crate's recursion_limit to 256.

Testing

Extend the UI fixture to expect an uncommented-argument warning for OptionalString::None, where OptionalString aliases Option<String>.

## What changed

- Move the lint to `nightly-2026-08-20` and Dylint `6.1.0`, updating CI, release artifacts, Bazel configuration, and installation instructions.
- Adapt to the updated rustc and Clippy APIs, including resolving `Option::None` through type aliases when checking for uncommented arguments.
- Set the `chatgpt` crate's `recursion_limit` to `256`.

## Testing

Extend the UI fixture to expect an uncommented-argument warning for `OptionalString::None`, where `OptionalString` aliases `Option<String>`.

GitOrigin-RevId: 34e1b173972f0bfa9b6c8fd3342ca652539efe2f
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/34e1b173972f0bfa9b6c8fd3342ca652539efe2f branch from 3ede8c5 to 17e5a4d Compare September 30, 2026 18:49
@copyberry
copyberry Bot merged commit 17e5a4d into main Sep 30, 2026
1 check passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/34e1b173972f0bfa9b6c8fd3342ca652539efe2f branch September 30, 2026 18:49
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 30, 2026

This branch was successfully deployed

1 active deployment
issue-triage — 17e5a4db Deployed Sep 30, 2026 by NguyenAnh718 via Translate non-English issue #16438
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants