Repository navigation
Complete turn abort callbacks before emitting terminal events - #49475
Merged
copyberry[bot] merged 1 commit intoSep 30, 2026
Conversation
## Why `TurnAborted` could be emitted before extension abort callbacks finished, allowing consumers to observe a terminal event while lifecycle cleanup was still pending. ## What changed Await `on_turn_abort` within task abort handling before emitting `TurnAborted`, retaining callback delivery for already-cancelled tasks. Document that `on_turn_stop` and `on_turn_abort` complete before their corresponding terminal events, if emitted. ## Testing Add regression coverage for interrupt, conditional interrupt, and shutdown. Hold the abort callback open to verify that `TurnAborted` waits for completion, then verify that the callback runs exactly once with the expected turn ID and abort reason. GitOrigin-RevId: f34d7e94d04c02544178dc445b85abc65a6ce499
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/f34d7e94d04c02544178dc445b85abc65a6ce499
branch
from
September 30, 2026 03:45
9dd6fbd to
9ef9cb1
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/f34d7e94d04c02544178dc445b85abc65a6ce499
branch
September 30, 2026 03:45
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complete turn abort callbacks before emitting terminal events
Why
TurnAbortedcould be emitted before extension abort callbacks finished, allowing consumers to observe a terminal event while lifecycle cleanup was still pending.What changed
Await
on_turn_abortwithin task abort handling before emittingTurnAborted, retaining callback delivery for already-cancelled tasks. Document thaton_turn_stopandon_turn_abortcomplete before their corresponding terminal events, if emitted.Testing
Add regression coverage for interrupt, conditional interrupt, and shutdown. Hold the abort callback open to verify that
TurnAbortedwaits for completion, then verify that the callback runs exactly once with the expected turn ID and abort reason.