Repository navigation
Enable analytics by default for daemon-launched app servers - #49426
Merged
copyberry[bot] merged 1 commit intoSep 30, 2026
Conversation
## Why Daemon-launched app servers should use the same analytics default as first-party clients while honoring explicit user opt-outs. ## What changed Pass `--analytics-default-enabled` when the PID backend launches an app server, with or without remote control. Users can still disable analytics with `analytics.enabled = false` in `config.toml`. ## Testing Update argument assertions for both remote-control modes and the daemon start/restart test to expect the analytics flag alongside launch feature overrides. GitOrigin-RevId: 8a222a00fc56737f5fe2b0385abf59466d1a6671
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/8a222a00fc56737f5fe2b0385abf59466d1a6671
branch
from
September 30, 2026 01:35
04154dd to
2cc65cd
Compare
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/8a222a00fc56737f5fe2b0385abf59466d1a6671
branch
September 30, 2026 01:35
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable analytics by default for daemon-launched app servers
Why
Daemon-launched app servers should use the same analytics default as first-party clients while honoring explicit user opt-outs.
What changed
Pass
--analytics-default-enabledwhen the PID backend launches an app server, with or without remote control. Users can still disable analytics withanalytics.enabled = falseinconfig.toml.Testing
Update argument assertions for both remote-control modes and the daemon start/restart test to expect the analytics flag alongside launch feature overrides.