Repository navigation
Serialize tests that share Windows sandbox accounts - #49389
Merged
copyberry[bot] merged 1 commit intoSep 29, 2026
Merged
copyberry[bot] merged 1 commit into
copyberry[bot] merged 1 commit into
Conversation
## Why Elevated sandbox tests share machine-local Windows accounts. Concurrent setup can rotate account passwords between another test's setup and logon. ## What changed - Add a shared file-lock guard for elevated sandbox tests in `codex-core`, `codex-exec-server`, and `codex-windows-sandbox`, held through sandbox commands and cleanup. - Queue these tests in a single-threaded Nextest group before their timeouts start, while retaining the file lock to coordinate other test processes. - Limit account locking to tests that use elevated accounts and remove the sandbox crate's blanket Bazel `exclusive-if-local` tag. GitOrigin-RevId: 26d4606cb1fdcac65926d29835bed4eac04c19c0
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/26d4606cb1fdcac65926d29835bed4eac04c19c0
branch
from
September 29, 2026 22:50
ee5c296 to
9212b3e
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/26d4606cb1fdcac65926d29835bed4eac04c19c0
branch
September 29, 2026 22:50
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Serialize tests that share Windows sandbox accounts
Why
Elevated sandbox tests share machine-local Windows accounts. Concurrent setup can rotate account passwords between another test's setup and logon.
What changed
codex-core,codex-exec-server, andcodex-windows-sandbox, held through sandbox commands and cleanup.exclusive-if-localtag.