Repository navigation
[0.160] Backport remaining Windows console fix to frozen alpha.6 - #49386
Merged
andrewgu-oai merged 1 commit intoSep 29, 2026
Merged
andrewgu-oai merged 1 commit into
andrewgu-oai merged 1 commit into
Conversation
## What changed Use `ConsoleMode::NoWindow` for legacy Windows sandbox capture and non-TTY unified execution, enabling `CREATE_NO_WINDOW` for these piped processes. ## Testing Extend the PowerShell interrupt and capture tests to assert that `GetConsoleWindow()` returns null before checking process termination and descendant survival. GitOrigin-RevId: dcc3b5554986ab0280748e5fa7080d36ded3d673 (cherry picked from commit 50d9c5d)
andrewgu-oai
marked this pull request as ready for review
September 29, 2026 22:46
Contributor
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
andrewgu-oai
enabled auto-merge (squash)
September 29, 2026 22:49
andrewgu-oai
disabled auto-merge
September 29, 2026 22:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #49308 onto the frozen 0.160.0-alpha.6 content commit c248f6d for the Windows console flashing issue #48074. That base already contains #49164, so only the missing patch is included. This does not advance the baked candidate to current main or publish stable 0.160.
The cherry-pick applied cleanly and its stable patch ID matches upstream.
git diff --checkpasses. Native Windows validation on this exact candidate is still pending. Keep this PR in draft pending review, required checks, and focused unelevated-sandbox smoke evidence for external processes (whoami.exe, cmd.exe, Git, nested PowerShell), alongside built-ins, with and without the managed daemon. Record exact candidate SHA, CLI/daemon versions, CODEX_HOME, configuration, command output, exit codes, duration and visible console observations.The unresolved hang report at #48074 (comment) is not proof these changes caused a regression, but requires investigation before treating the candidate as validated.