Repository navigation
Compile hook matchers during discovery - #49379
Merged
copyberry[bot] merged 1 commit intoSep 29, 2026
Merged
copyberry[bot] merged 1 commit into
copyberry[bot] merged 1 commit into
Conversation
## Why Hook dispatch recompiles regex matchers for each input even though discovery already validates them. ## What changed Store compiled `HookMatcher` values on configured handlers and reuse them during dispatch. Preserve match-all, exact-name, pipe-alternative, and regex matching semantics, along with the original pattern spelling for configuration equality. Invalid regexes continue to be rejected during discovery. GitOrigin-RevId: 117a8a19c7bc0e55ccbedcd5940b806a17ebba10
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/117a8a19c7bc0e55ccbedcd5940b806a17ebba10
branch
from
September 29, 2026 22:05
7fa45fb to
bd4204e
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/117a8a19c7bc0e55ccbedcd5940b806a17ebba10
branch
September 29, 2026 22:05
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compile hook matchers during discovery
Why
Hook dispatch recompiles regex matchers for each input even though discovery already validates them.
What changed
Store compiled
HookMatchervalues on configured handlers and reuse them during dispatch. Preserve match-all, exact-name, pipe-alternative, and regex matching semantics, along with the original pattern spelling for configuration equality. Invalid regexes continue to be rejected during discovery.