Skip to content

Compile hook matchers during discovery - #49379

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/117a8a19c7bc0e55ccbedcd5940b806a17ebba10
Sep 29, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/117a8a19c7bc0e55ccbedcd5940b806a17ebba10

Conversation

@copyberry

@copyberry copyberry Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Compile hook matchers during discovery

Why

Hook dispatch recompiles regex matchers for each input even though discovery already validates them.

What changed

Store compiled HookMatcher values on configured handlers and reuse them during dispatch. Preserve match-all, exact-name, pipe-alternative, and regex matching semantics, along with the original pattern spelling for configuration equality. Invalid regexes continue to be rejected during discovery.

## Why

Hook dispatch recompiles regex matchers for each input even though discovery already validates them.

## What changed

Store compiled `HookMatcher` values on configured handlers and reuse them during dispatch. Preserve match-all, exact-name, pipe-alternative, and regex matching semantics, along with the original pattern spelling for configuration equality. Invalid regexes continue to be rejected during discovery.

GitOrigin-RevId: 117a8a19c7bc0e55ccbedcd5940b806a17ebba10
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/117a8a19c7bc0e55ccbedcd5940b806a17ebba10 branch from 7fa45fb to bd4204e Compare September 29, 2026 22:05
@copyberry
copyberry Bot merged commit bd4204e into main Sep 29, 2026
5 of 8 checks passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/117a8a19c7bc0e55ccbedcd5940b806a17ebba10 branch September 29, 2026 22:05
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 29, 2026
@rafaself
rafaself deployed to issue-triage September 29, 2026 22:15 — with GitHub Actions Active
@rafaself
rafaself deployed to issue-triage September 29, 2026 22:15 — with GitHub Actions Active
@rafaself
rafaself deployed to issue-triage September 29, 2026 22:15 — with GitHub Actions Active
@ChrisF0
ChrisF0 deployed to issue-triage September 29, 2026 22:15 — with GitHub Actions Active
@ChrisF0
ChrisF0 deployed to issue-triage September 29, 2026 22:15 — with GitHub Actions Active
@ChrisF0
ChrisF0 deployed to issue-triage September 29, 2026 22:15 — with GitHub Actions Active
@rafaself
rafaself deployed to issue-triage September 29, 2026 22:17 — with GitHub Actions Active
@rafaself
rafaself deployed to issue-triage September 29, 2026 22:17 — with GitHub Actions Active
@rafaself
rafaself deployed to issue-triage September 29, 2026 22:17 — with GitHub Actions Active

This branch was successfully deployed

1 active deployment
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants