Skip to content

Run piped legacy Windows sandbox processes without a console - #49308

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/dcc3b5554986ab0280748e5fa7080d36ded3d673
Sep 29, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/dcc3b5554986ab0280748e5fa7080d36ded3d673

Conversation

@copyberry

@copyberry copyberry Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Run piped legacy Windows sandbox processes without a console

What changed

Use ConsoleMode::NoWindow for legacy Windows sandbox capture and non-TTY unified execution, enabling CREATE_NO_WINDOW for these piped processes.

Testing

Extend the PowerShell interrupt and capture tests to assert that GetConsoleWindow() returns null before checking process termination and descendant survival.

## What changed

Use `ConsoleMode::NoWindow` for legacy Windows sandbox capture and non-TTY unified execution, enabling `CREATE_NO_WINDOW` for these piped processes.

## Testing

Extend the PowerShell interrupt and capture tests to assert that `GetConsoleWindow()` returns null before checking process termination and descendant survival.

GitOrigin-RevId: dcc3b5554986ab0280748e5fa7080d36ded3d673
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/dcc3b5554986ab0280748e5fa7080d36ded3d673 branch from 68bdf28 to 50d9c5d Compare September 29, 2026 16:39
@copyberry
copyberry Bot merged commit 50d9c5d into main Sep 29, 2026
1 check passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/dcc3b5554986ab0280748e5fa7080d36ded3d673 branch September 29, 2026 16:39
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 29, 2026
@arimxyer
arimxyer deployed to issue-triage September 29, 2026 16:41 — with GitHub Actions Active
@arimxyer
arimxyer deployed to issue-triage September 29, 2026 16:41 — with GitHub Actions Active
@arimxyer
arimxyer deployed to issue-triage September 29, 2026 16:41 — with GitHub Actions Active
@arimxyer
arimxyer deployed to issue-triage September 29, 2026 16:42 — with GitHub Actions Active
@edgework
edgework deployed to issue-triage September 29, 2026 16:47 — with GitHub Actions Active
@edgework
edgework deployed to issue-triage September 29, 2026 16:47 — with GitHub Actions Active
@edgework
edgework deployed to issue-triage September 29, 2026 16:47 — with GitHub Actions Active

This branch was successfully deployed

1 active deployment
issue-triage — 50d9c5de Deployed Sep 29, 2026 by edgework via Translate non-English issue #16114
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants