Repository navigation
Scan the session index backwards for batch thread name lookups - #49297
Merged
copyberry[bot] merged 1 commit intoSep 29, 2026
Conversation
## Why Batch thread name lookups read the entire append-only session index even when all requested names could be found near the end. ## What changed Use `ReverseJsonlScanner` in `spawn_blocking` for `find_thread_names_by_ids`, stopping once every requested ID has a usable name. Preserve the latest nonempty, trimmed name for each ID while skipping malformed entries. ## Testing Add regression coverage for renamed threads, whitespace-only names, Unicode, reads across chunk boundaries, malformed entries, a partial final write, and missing IDs. GitOrigin-RevId: 2ab9254ba8b718fe3e02c47fc9b0de20c09fd10f
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/2ab9254ba8b718fe3e02c47fc9b0de20c09fd10f
branch
from
September 29, 2026 16:16
7aa3598 to
d5e6526
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/2ab9254ba8b718fe3e02c47fc9b0de20c09fd10f
branch
September 29, 2026 16:16
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scan the session index backwards for batch thread name lookups
Why
Batch thread name lookups read the entire append-only session index even when all requested names could be found near the end.
What changed
Use
ReverseJsonlScannerinspawn_blockingforfind_thread_names_by_ids, stopping once every requested ID has a usable name. Preserve the latest nonempty, trimmed name for each ID while skipping malformed entries.Testing
Add regression coverage for renamed threads, whitespace-only names, Unicode, reads across chunk boundaries, malformed entries, a partial final write, and missing IDs.