Repository navigation
Simplify configuration fingerprint canonicalization - #49295
Merged
copyberry[bot] merged 1 commit intoSep 29, 2026
Merged
copyberry[bot] merged 1 commit into
copyberry[bot] merged 1 commit into
Conversation
## What changed Replace the custom recursive JSON canonicalizer with `serde_json::Value::sort_all_objects()` before hashing configuration values, preserving existing fingerprints. ## Testing Add a regression test that checks reordered keys in nested tables and tables inside arrays produce the same existing fingerprint. GitOrigin-RevId: 890e79865a1d690adea3b35f19fcc6c30dbd17ce
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/890e79865a1d690adea3b35f19fcc6c30dbd17ce
branch
from
September 29, 2026 16:10
d129977 to
cf12c86
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/890e79865a1d690adea3b35f19fcc6c30dbd17ce
branch
September 29, 2026 16:10
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify configuration fingerprint canonicalization
What changed
Replace the custom recursive JSON canonicalizer with
serde_json::Value::sort_all_objects()before hashing configuration values, preserving existing fingerprints.Testing
Add a regression test that checks reordered keys in nested tables and tables inside arrays produce the same existing fingerprint.