Skip to content

Restrict capability roots to captured turn environments - #49280

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/afe375047cc5e8aad06df83334149510460dcdcc
Sep 29, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/afe375047cc5e8aad06df83334149510460dcdcc

Conversation

@copyberry

@copyberry copyberry Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Restrict capability roots to captured turn environments

Why

Stale thread capability roots can reconnect executors that are not selected for the current turn and shadow selected roots with the same ID.

What changed

Filter out roots whose environments are absent from the turn snapshot before deduplication and readiness resolution. Update app-server capability tests to explicitly select the executor environments used by each turn, including after resume.

Testing

Add regression coverage for full-access and workspace-write permissions, verifying that stale roots never connect an unselected executor, selected roots with matching IDs remain available, and turns with no environments expose no roots.

## Why

Stale thread capability roots can reconnect executors that are not selected for the current turn and shadow selected roots with the same ID.

## What changed

Filter out roots whose environments are absent from the turn snapshot before deduplication and readiness resolution. Update app-server capability tests to explicitly select the executor environments used by each turn, including after resume.

## Testing

Add regression coverage for full-access and workspace-write permissions, verifying that stale roots never connect an unselected executor, selected roots with matching IDs remain available, and turns with no environments expose no roots.

GitOrigin-RevId: afe375047cc5e8aad06df83334149510460dcdcc
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/afe375047cc5e8aad06df83334149510460dcdcc branch from e84be86 to 18194bf Compare September 29, 2026 15:10
@copyberry
copyberry Bot merged commit 18194bf into main Sep 29, 2026
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/afe375047cc5e8aad06df83334149510460dcdcc branch September 29, 2026 15:10
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 29, 2026
@Fredoooou
Fredoooou deployed to issue-triage September 29, 2026 15:23 — with GitHub Actions Active
@Fredoooou
Fredoooou deployed to issue-triage September 29, 2026 15:23 — with GitHub Actions Active
@Fredoooou
Fredoooou deployed to issue-triage September 29, 2026 15:23 — with GitHub Actions Active
@Fredoooou
Fredoooou deployed to issue-triage September 29, 2026 15:24 — with GitHub Actions Active
@zybczy
zybczy deployed to issue-triage September 29, 2026 15:32 — with GitHub Actions Active
@zybczy
zybczy deployed to issue-triage September 29, 2026 15:32 — with GitHub Actions Active
@zybczy
zybczy deployed to issue-triage September 29, 2026 15:32 — with GitHub Actions Active
@zybczy
zybczy deployed to issue-triage September 29, 2026 15:34 — with GitHub Actions Active

This branch was successfully deployed

1 active deployment
issue-triage — 18194bfd Deployed Sep 29, 2026 by maloumalmal-jpg via Identify potential duplicates (all issues) #49787
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants