Repository navigation
Preserve Windows sandbox runner launch errors - #49261
Merged
copyberry[bot] merged 1 commit intoSep 29, 2026
Merged
copyberry[bot] merged 1 commit into
copyberry[bot] merged 1 commit into
Conversation
## Why Restoring the error mode with `SetErrorMode` can overwrite the failure code from `CreateProcessWithLogonW`, causing `RunnerLogonError` to report the wrong error. ## What changed Capture `GetLastError()` immediately after a failed runner launch, before restoring the previous error mode, and use the saved code for `RunnerLogonError`. GitOrigin-RevId: c0f4267232306be4d06e7e8accd60f7b77b8d6f3
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/c0f4267232306be4d06e7e8accd60f7b77b8d6f3
branch
from
September 29, 2026 13:09
0579f7f to
f35a0fd
Compare
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/c0f4267232306be4d06e7e8accd60f7b77b8d6f3
branch
September 29, 2026 13:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve Windows sandbox runner launch errors
Why
Restoring the error mode with
SetErrorModecan overwrite the failure code fromCreateProcessWithLogonW, causingRunnerLogonErrorto report the wrong error.What changed
Capture
GetLastError()immediately after a failed runner launch, before restoring the previous error mode, and use the saved code forRunnerLogonError.