Repository navigation
Keep configuration values out of Windows sandbox policy events - #49067
Merged
copyberry[bot] merged 1 commit intoSep 28, 2026
Conversation
## Why Configuration parser errors can include entire configuration lines containing credentials. Persistent policy-rejection events must avoid recording those values. ## What changed Replace free-form error text in Windows sandbox provisioning policy-rejection events with known stage labels and typed cloud, HTTP, I/O, and Win32 error codes. Use fixed fallback labels when the stage or cause is unrecognized. ## Testing Add regression coverage using malformed requirements and cloud configuration fragments containing a synthetic secret. Verify that diagnostics exclude parser values while retaining safe error codes, and that unknown errors produce fixed fallback text. GitOrigin-RevId: 4f2fa5f6f602c34451776ec31381a102213660b8
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/4f2fa5f6f602c34451776ec31381a102213660b8
branch
from
September 28, 2026 19:56
2ff3ef2 to
5a5a4aa
Compare
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/4f2fa5f6f602c34451776ec31381a102213660b8
branch
September 28, 2026 19:56
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep configuration values out of Windows sandbox policy events
Why
Configuration parser errors can include entire configuration lines containing credentials. Persistent policy-rejection events must avoid recording those values.
What changed
Replace free-form error text in Windows sandbox provisioning policy-rejection events with known stage labels and typed cloud, HTTP, I/O, and Win32 error codes. Use fixed fallback labels when the stage or cause is unrecognized.
Testing
Add regression coverage using malformed requirements and cloud configuration fragments containing a synthetic secret. Verify that diagnostics exclude parser values while retaining safe error codes, and that unknown errors produce fixed fallback text.