Skip to content

Preserve independent Guardian history across parent compaction - #48779

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/fea0852cc5537372854f4a34bacb6bfda6d13e88
Sep 27, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/fea0852cc5537372854f4a34bacb6bfda6d13e88

Conversation

@copyberry

@copyberry copyberry Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Preserve independent Guardian history across parent compaction

Why

Guardian reviews need to retain original evidence across parent compaction when checkpoint reuse is disabled, including after resume and rollback.

What changed

  • Make disabling guardian_reuse_parent_compaction select a bounded, independent review transcript while preserving thread-owned authorization.
  • Keep synchronous reviews and asynchronous scoring independent of parent checkpoints, and allow reviewer sessions to continue using transcript deltas across parent compaction.
  • Persist transcript entries with rollback provenance while remaining compatible with older checkpoint readers and metadata-free checkpoints.
  • Exclude compaction output from the transcript and synthetic summaries from rollback turn boundaries. Use acceptance ordering to remove rolled-back evidence even when persistence order differs.

Testing

Add regression coverage for reviewer continuity, evidence retention across compaction and resume, rollback after local and remote compaction, and checkpoint serialization compatibility.

## Why

Guardian reviews need to retain original evidence across parent compaction when checkpoint reuse is disabled, including after resume and rollback.

## What changed

- Make disabling `guardian_reuse_parent_compaction` select a bounded, independent review transcript while preserving thread-owned authorization.
- Keep synchronous reviews and asynchronous scoring independent of parent checkpoints, and allow reviewer sessions to continue using transcript deltas across parent compaction.
- Persist transcript entries with rollback provenance while remaining compatible with older checkpoint readers and metadata-free checkpoints.
- Exclude compaction output from the transcript and synthetic summaries from rollback turn boundaries. Use acceptance ordering to remove rolled-back evidence even when persistence order differs.

## Testing

Add regression coverage for reviewer continuity, evidence retention across compaction and resume, rollback after local and remote compaction, and checkpoint serialization compatibility.

GitOrigin-RevId: fea0852cc5537372854f4a34bacb6bfda6d13e88
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/fea0852cc5537372854f4a34bacb6bfda6d13e88 branch from a5f5d28 to 21eb355 Compare September 27, 2026 20:15
@copyberry
copyberry Bot merged commit 21eb355 into main Sep 27, 2026
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/fea0852cc5537372854f4a34bacb6bfda6d13e88 branch September 27, 2026 20:15
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 27, 2026
@firtman
firtman deployed to issue-triage September 27, 2026 20:30 — with GitHub Actions Active
@firtman
firtman deployed to issue-triage September 27, 2026 20:30 — with GitHub Actions Active
@firtman
firtman deployed to issue-triage September 27, 2026 20:30 — with GitHub Actions Active

This branch was successfully deployed

1 active deployment
issue-triage — 21eb3551 Deployed Sep 27, 2026 by jiri-otoupal via Generate label suggestions #49157
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants