Repository navigation
Prevent console windows for piped Windows child processes - #48483
Merged
copyberry[bot] merged 1 commit intoSep 26, 2026
Conversation
## Why Piped child processes launched from a detached Windows process should not allocate a console window. ## What changed Set `CREATE_NO_WINDOW` by default for `codex-rs/utils/pty` child commands. Preserve it alongside `CREATE_SUSPENDED` when preparing a child for Job Object containment, since Tokio's `creation_flags` replaces existing flags. ## Testing Add a Windows regression test that runs from a detached process and verifies that children have no console window and retain working piped stdin and stdout, both with and without Job Object containment. GitOrigin-RevId: 990386032d74fa783a66bb20faff769539ea41c1
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/990386032d74fa783a66bb20faff769539ea41c1
branch
from
September 26, 2026 16:46
03ca680 to
1a89aec
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/990386032d74fa783a66bb20faff769539ea41c1
branch
September 26, 2026 16:46
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent console windows for piped Windows child processes
Why
Piped child processes launched from a detached Windows process should not allocate a console window.
What changed
Set
CREATE_NO_WINDOWby default forcodex-rs/utils/ptychild commands. Preserve it alongsideCREATE_SUSPENDEDwhen preparing a child for Job Object containment, since Tokio'screation_flagsreplaces existing flags.Testing
Add a Windows regression test that runs from a detached process and verifies that children have no console window and retain working piped stdin and stdout, both with and without Job Object containment.