Skip to content

Enforce current provider requirements for the model catalog - #46917

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/03127bba46f1f59f2a8b1dc37391eab75f9be23c
Sep 21, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/03127bba46f1f59f2a8b1dc37391eab75f9be23c

Conversation

@copyberry

@copyberry copyberry Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Enforce current provider requirements for the model catalog

Why

The app server retains its startup model provider, but managed provider requirements can change while it is running. Catalog reads and background refreshes must check those requirements even when models are cached.

What changed

  • Gate model/list and background refreshes through a shared catalog that validates the startup provider against current requirements.
  • Return JSON-RPC error -32600 with restart guidance when the provider no longer complies, and skip background requests to that endpoint. Requirement load failures also block catalog access.
  • Log only the error kind for blocked refreshes to avoid exposing credentials in parser diagnostics.

Testing

Add coverage for cached catalog access after provider selection or definition changes, invalid requirements, cloud configuration load failures, and recovery when requirements allow the retained provider again. Extend refresh tests to cover startup provider overrides, blocked endpoint requests, and credential-safe logging.

## Why

The app server retains its startup model provider, but managed provider requirements can change while it is running. Catalog reads and background refreshes must check those requirements even when models are cached.

## What changed

- Gate `model/list` and background refreshes through a shared catalog that validates the startup provider against current requirements.
- Return JSON-RPC error `-32600` with restart guidance when the provider no longer complies, and skip background requests to that endpoint. Requirement load failures also block catalog access.
- Log only the error kind for blocked refreshes to avoid exposing credentials in parser diagnostics.

## Testing

Add coverage for cached catalog access after provider selection or definition changes, invalid requirements, cloud configuration load failures, and recovery when requirements allow the retained provider again. Extend refresh tests to cover startup provider overrides, blocked endpoint requests, and credential-safe logging.

GitOrigin-RevId: 03127bba46f1f59f2a8b1dc37391eab75f9be23c
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/03127bba46f1f59f2a8b1dc37391eab75f9be23c branch from 13d7757 to 75db67b Compare September 21, 2026 01:19
@copyberry
copyberry Bot merged commit 75db67b into main Sep 21, 2026
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/03127bba46f1f59f2a8b1dc37391eab75f9be23c branch September 21, 2026 01:19
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 21, 2026
@jsc7727
jsc7727 deployed to issue-triage September 21, 2026 01:33 — with GitHub Actions Active
@jsc7727
jsc7727 deployed to issue-triage September 21, 2026 01:33 — with GitHub Actions Active
@jsc7727
jsc7727 deployed to issue-triage September 21, 2026 01:33 — with GitHub Actions Active
@jsc7727
jsc7727 deployed to issue-triage September 21, 2026 01:34 — with GitHub Actions Active
@ljjay
ljjay deployed to issue-triage September 21, 2026 01:43 — with GitHub Actions Active
@ljjay
ljjay deployed to issue-triage September 21, 2026 01:43 — with GitHub Actions Active
@ljjay
ljjay deployed to issue-triage September 21, 2026 01:43 — with GitHub Actions Active
@ljjay
ljjay deployed to issue-triage September 21, 2026 01:44 — with GitHub Actions Active
@retarder1
retarder1 deployed to issue-triage September 21, 2026 02:01 — with GitHub Actions Active
@retarder1
retarder1 deployed to issue-triage September 21, 2026 02:01 — with GitHub Actions Active
@retarder1
retarder1 deployed to issue-triage September 21, 2026 02:01 — with GitHub Actions Active

This branch was successfully deployed

1 active deployment
issue-triage — 75db67bb Deployed Sep 21, 2026 by retarder1 via Generate label suggestions #47052
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants