Skip to content

Standardize TUI picker presentation and fix wrapping boundaries - #46691

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/8416bcd3c66b6cd15db3f9c1804f5f005b7964c1
Sep 19, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/8416bcd3c66b6cd15db3f9c1804f5f005b7964c1

Conversation

@copyberry

@copyberry copyberry Bot commented Sep 19, 2026 •

Copy link
Copy Markdown

Standardize TUI picker presentation and fix wrapping boundaries

Why

Menu layouts and hints vary across TUI flows, and mismatched measurement and rendering widths can clip subsequent choices when descriptions wrap.

What changed

  • Apply shared picker styling across selection menus, with stable columns, descriptions hidden when space is tight, and compact hints derived from configured key bindings.
  • Measure rows at their actual rendering width, including caller insets, so wrapped options receive enough space.
  • Wrap model menu headers and shortcut capture content, and use the shared panel surface for shortcut capture.
  • Indicate clipped headers in non-searchable menus and show the configured view all shortcut only when the view supplies one.

Testing

Add regression tests and snapshots for wrapping boundaries, narrow picker layouts, configured selection and cancellation keys, and clipped approval headers. Verify that copy/export actions retain complete payloads and composer drafts.

## Why

Menu layouts and hints vary across TUI flows, and mismatched measurement and rendering widths can clip subsequent choices when descriptions wrap.

## What changed

- Apply shared picker styling across selection menus, with stable columns, descriptions hidden when space is tight, and compact hints derived from configured key bindings.
- Measure rows at their actual rendering width, including caller insets, so wrapped options receive enough space.
- Wrap model menu headers and shortcut capture content, and use the shared panel surface for shortcut capture.
- Indicate clipped headers in non-searchable menus and show the configured `view all` shortcut only when the view supplies one.

## Testing

Add regression tests and snapshots for wrapping boundaries, narrow picker layouts, configured selection and cancellation keys, and clipped approval headers. Verify that copy/export actions retain complete payloads and composer drafts.

GitOrigin-RevId: 8416bcd3c66b6cd15db3f9c1804f5f005b7964c1
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/8416bcd3c66b6cd15db3f9c1804f5f005b7964c1 branch from cbd3345 to 79d2144 Compare September 19, 2026 19:12
@copyberry
copyberry Bot merged commit 79d2144 into main Sep 19, 2026
1 check passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/8416bcd3c66b6cd15db3f9c1804f5f005b7964c1 branch September 19, 2026 19:12
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 19, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant