Skip to content

Extend server version notices to prerelease and local clients - #46673

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/29df4713a7dbcbddcf30d56995a8496e7e8d0c6a
Sep 19, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/29df4713a7dbcbddcf30d56995a8496e7e8d0c6a

Conversation

@copyberry

@copyberry copyberry Bot commented Sep 19, 2026 •

Copy link
Copy Markdown

Extend server version notices to prerelease and local clients

Why

Server version notices previously required both versions to be stable releases, leaving prerelease and local clients without notices about differing background services.

What changed

  • Use semantic version parsing to distinguish older servers from version mismatches.
  • Compare stable clients against older releases, including prereleases. Compare prerelease clients by precedence within the same release line and report other release lines as different.
  • Report differing versions for local clients (0.0.0 or versions with build metadata). Ignore malformed versions.
  • Show the corresponding older than or different from notice and < or ≠ overview indicator, while preserving /daemon guidance and the show_server_version_notice setting.

Testing

Add version-policy tests and notice snapshots covering prerelease ordering, local builds, mismatches, and malformed versions. Add daemon tests for notice suppression and manual update guidance without scheduling an update.

## Why

Server version notices previously required both versions to be stable releases, leaving prerelease and local clients without notices about differing background services.

## What changed

- Use semantic version parsing to distinguish older servers from version mismatches.
- Compare stable clients against older releases, including prereleases. Compare prerelease clients by precedence within the same release line and report other release lines as different.
- Report differing versions for local clients (`0.0.0` or versions with build metadata). Ignore malformed versions.
- Show the corresponding `older than` or `different from` notice and `<` or `≠` overview indicator, while preserving `/daemon` guidance and the `show_server_version_notice` setting.

## Testing

Add version-policy tests and notice snapshots covering prerelease ordering, local builds, mismatches, and malformed versions. Add daemon tests for notice suppression and manual update guidance without scheduling an update.

GitOrigin-RevId: 29df4713a7dbcbddcf30d56995a8496e7e8d0c6a
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/29df4713a7dbcbddcf30d56995a8496e7e8d0c6a branch from 44befd8 to a529002 Compare September 19, 2026 17:03
@copyberry
copyberry Bot merged commit a529002 into main Sep 19, 2026
1 check passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/29df4713a7dbcbddcf30d56995a8496e7e8d0c6a branch September 19, 2026 17:03
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 19, 2026
@gerialkot
gerialkot deployed to issue-triage September 19, 2026 17:07 — with GitHub Actions Active
@gerialkot
gerialkot deployed to issue-triage September 19, 2026 17:07 — with GitHub Actions Active
@gerialkot
gerialkot deployed to issue-triage September 19, 2026 17:07 — with GitHub Actions Active
@gerialkot
gerialkot deployed to issue-triage September 19, 2026 17:08 — with GitHub Actions Active
@Haberno
Haberno deployed to issue-triage September 19, 2026 17:31 — with GitHub Actions Active
@Haberno
Haberno deployed to issue-triage September 19, 2026 17:31 — with GitHub Actions Active
@Haberno
Haberno deployed to issue-triage September 19, 2026 17:31 — with GitHub Actions Active
@Haberno
Haberno deployed to issue-triage September 19, 2026 17:33 — with GitHub Actions Active
@izicafe
izicafe deployed to issue-triage September 19, 2026 17:39 — with GitHub Actions Active
@izicafe
izicafe deployed to issue-triage September 19, 2026 17:39 — with GitHub Actions Active
@izicafe
izicafe deployed to issue-triage September 19, 2026 17:39 — with GitHub Actions Active

This branch was successfully deployed

1 active deployment
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants