Repository navigation
Add system proxy fallback for login and startup requests - #46562
Merged
copyberry[bot] merged 1 commit intoSep 19, 2026
Merged
copyberry[bot] merged 1 commit into
copyberry[bot] merged 1 commit into
Conversation
## Why Login and enterprise configuration bootstrap can fail when their endpoints are reachable only through the system proxy, before cloud configuration can enable `respect_system_proxy`. ## What changed - Enable `features.system_proxy_fallback` by default, honor managed feature requirements, and prevent project configuration from changing it. - Retry account discovery and cloud configuration GETs through the system proxy after connection failures or timeouts, bounding the initial request and body read to five seconds. - Retry OAuth authorization-code exchange only on connection failures before any redirect, with a ten-second connection timeout. Reuse the successful client for the subsequent API-key exchange to avoid changing routes. - Increase workspace discovery and cloud configuration timeouts to 15 and 20 seconds, respectively, to accommodate fallback. ## Testing Add coverage for proxy-only browser login through the first completed turn, including cloud configuration enabling `respect_system_proxy` without a restart. Cover stalled GET bodies, preserved request headers, disabled fallback, managed requirements, and project configuration restrictions. Verify that OAuth HTTP errors, redirects followed by connection failures, and failures after sending the POST do not trigger proxy retries, while successful redirects remain supported. GitOrigin-RevId: 854eeeac186bb4865218ce645019c1e4bff85425
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/854eeeac186bb4865218ce645019c1e4bff85425
branch
from
September 19, 2026 01:37
e808e9a to
3bb0a53
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/854eeeac186bb4865218ce645019c1e4bff85425
branch
September 19, 2026 01:37
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add system proxy fallback for login and startup requests
Why
Login and enterprise configuration bootstrap can fail when their endpoints are reachable only through the system proxy, before cloud configuration can enable
respect_system_proxy.What changed
features.system_proxy_fallbackby default, honor managed feature requirements, and prevent project configuration from changing it.Testing
Add coverage for proxy-only browser login through the first completed turn, including cloud configuration enabling
respect_system_proxywithout a restart. Cover stalled GET bodies, preserved request headers, disabled fallback, managed requirements, and project configuration restrictions. Verify that OAuth HTTP errors, redirects followed by connection failures, and failures after sending the POST do not trigger proxy retries, while successful redirects remain supported.