Skip to content

Extract shared footer hint wrapping in the TUI - #44354

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/4d8ead0acbfa3bf9241baedb86d2476566d26ebc
Sep 10, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/4d8ead0acbfa3bf9241baedb86d2476566d26ebc

Conversation

@copyberry

@copyberry copyberry Bot commented Sep 10, 2026 •

Copy link
Copy Markdown

Extract shared footer hint wrapping in the TUI

What changed

Replace duplicated footer wrapping in the MCP elicitation and request-user-input overlays with wrap_hint_rows. Preserve whole-hint grouping, display-width and separator accounting, oversized hints, and the single empty row for empty input.

Testing

Add unit tests for Unicode display widths, whole-hint wrapping, oversized hints at zero width, and empty input.

## What changed

Replace duplicated footer wrapping in the MCP elicitation and request-user-input overlays with `wrap_hint_rows`. Preserve whole-hint grouping, display-width and separator accounting, oversized hints, and the single empty row for empty input.

## Testing

Add unit tests for Unicode display widths, whole-hint wrapping, oversized hints at zero width, and empty input.

GitOrigin-RevId: 4d8ead0acbfa3bf9241baedb86d2476566d26ebc
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/4d8ead0acbfa3bf9241baedb86d2476566d26ebc branch from 97df4a1 to e2a9ee0 Compare September 10, 2026 00:57
@copyberry
copyberry Bot merged commit e2a9ee0 into main Sep 10, 2026
1 check passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/4d8ead0acbfa3bf9241baedb86d2476566d26ebc branch September 10, 2026 00:57
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 10, 2026

This branch was previously deployed

1 inactive deployment
issue-triage — e2a9ee05 Deployed Sep 10, 2026 by aurindo10 via Generate label suggestions #44121
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants