Repository navigation
Add Windows MSVC Bazel targets for native voice libraries - #43144
Merged
copyberry[bot] merged 1 commit intoSep 6, 2026
Conversation
## What changed - Add explicit x64 and ARM64 targets for native builds, runtime preparation, and linking using the existing voice recipes. Each target requires native Windows execution of the matching architecture. - Declare compiler, SDK, Python, and CMake inputs; require an explicitly supplied Cygwin/pkgconf tool tree and a fixed `SystemRoot`. Validate installed tool selections against the manifest and declared files. - Pair Windows DLLs with SDK import libraries, preserve plugin and receipt runfiles, and omit Unix runtime-search flags. Use Python for portable payload copying. - Correct the MSVC ARM64 tool directory casing to `HostArm64` and document provisioning and build commands. The generic Rust-consumer aliases remain separate; native Windows Bazel execution and consumer validation are still needed to establish complete Windows voice support. ## Testing Add eight unit tests covering tool selection, path anchoring, invalid inputs, and DLL/import-library copying, plus x64 and ARM64 link smoke targets that reference `gst_version`. GitOrigin-RevId: fb2b4998e9ffb5b64ca830ebf4bb4633fc959eb9
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/fb2b4998e9ffb5b64ca830ebf4bb4633fc959eb9
branch
from
September 6, 2026 02:15
adb6df9 to
1c40ffe
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/fb2b4998e9ffb5b64ca830ebf4bb4633fc959eb9
branch
September 6, 2026 02:16
egecemkirci
temporarily deployed
to
issue-triage
September 6, 2026 02:18 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
egecemkirci
temporarily deployed
to
issue-triage
September 6, 2026 02:18 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
egecemkirci
temporarily deployed
to
issue-triage
September 6, 2026 02:18 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
egecemkirci
temporarily deployed
to
issue-triage
September 6, 2026 02:19 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Windows MSVC Bazel targets for native voice libraries
What changed
SystemRoot. Validate installed tool selections against the manifest and declared files.HostArm64and document provisioning and build commands.The generic Rust-consumer aliases remain separate; native Windows Bazel execution and consumer validation are still needed to establish complete Windows voice support.
Testing
Add eight unit tests covering tool selection, path anchoring, invalid inputs, and DLL/import-library copying, plus x64 and ARM64 link smoke targets that reference
gst_version.