Skip to content

Bound Noise handshakes by the exec server initialization timeout - #42623

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/c3eb5f7cfedd8d155fde5b7614fc2eb399ce337c
Sep 3, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/c3eb5f7cfedd8d155fde5b7614fc2eb399ce337c

Conversation

@copyberry

@copyberry copyberry Bot commented Sep 3, 2026 •

Copy link
Copy Markdown

Bound Noise handshakes by the exec server initialization timeout

What changed

  • Wait for the authenticated Noise handshake before sending the JSON-RPC
    initialize request.
  • Share the configured initialization timeout across the handshake and RPC,
    while preserving the configured duration in timeout diagnostics.
  • Record the handshake and initialization RPC as child spans of the existing
    initialization span, and terminate transport tasks when handshake readiness
    fails.

Testing

  • Cover stalled handshake timeouts and cleanup of the underlying WebSocket.
  • Cover timeout reporting after the handshake has consumed part of the budget.

)

## What changed

- Wait for the authenticated Noise handshake before sending the JSON-RPC
  `initialize` request.
- Share the configured initialization timeout across the handshake and RPC,
  while preserving the configured duration in timeout diagnostics.
- Record the handshake and initialization RPC as child spans of the existing
  initialization span, and terminate transport tasks when handshake readiness
  fails.

## Testing

- Cover stalled handshake timeouts and cleanup of the underlying WebSocket.
- Cover timeout reporting after the handshake has consumed part of the budget.

GitOrigin-RevId: c3eb5f7cfedd8d155fde5b7614fc2eb399ce337c
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/c3eb5f7cfedd8d155fde5b7614fc2eb399ce337c branch from cfd46cc to 781c183 Compare September 3, 2026 22:16
@copyberry
copyberry Bot merged commit 781c183 into main Sep 3, 2026
20 of 30 checks passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/c3eb5f7cfedd8d155fde5b7614fc2eb399ce337c branch September 3, 2026 22:18
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant