Repository navigation
Use ReviewDecision for MCP tool approvals - #38081
Merged
copyberry[bot] merged 1 commit intoAug 11, 2026
Merged
copyberry[bot] merged 1 commit into
copyberry[bot] merged 1 commit into
Conversation
## What changed - Add `ApprovedMcpPolicyAmendment` to represent MCP approvals that persist across sessions. - Route MCP approval responses directly through the shared `ReviewDecision` type while preserving session-only approvals, rejection reasons, timeouts, and cancellations. - Reject the MCP-only policy decision if it reaches command, shell, network, or other tool approval paths. ## Testing - Update MCP approval parsing, normalization, hook, and Guardian tests for the shared decisions. - Verify generic tool approvals reject MCP policy amendments. GitOrigin-RevId: b8cc931dc61d4c794915145273ede82b9eb30fc8
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/b8cc931dc61d4c794915145273ede82b9eb30fc8
branch
from
August 11, 2026 22:26
740d38c to
67afc79
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/b8cc931dc61d4c794915145273ede82b9eb30fc8
branch
August 11, 2026 22:27
garylesueur
temporarily deployed
to
issue-triage
August 11, 2026 22:40 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
garylesueur
temporarily deployed
to
issue-triage
August 11, 2026 22:40 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
garylesueur
temporarily deployed
to
issue-triage
August 11, 2026 22:40 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
ReviewDecisionfor MCP tool approvalsWhat changed
ApprovedMcpPolicyAmendmentto represent MCP approvals that persist across sessions.ReviewDecisiontype while preserving session-only approvals, rejection reasons, timeouts, and cancellations.Testing