Repository navigation
Streamline review and feedback handlers - #19498
Merged
Merged
Conversation
pakrym-oai
force-pushed
the
pakrym/appserver-errors-turn-realtime
branch
from
April 25, 2026 03:09
6fad0e6 to
9de37de
Compare
pakrym-oai
force-pushed
the
pakrym/appserver-errors-review-feedback
branch
from
April 25, 2026 03:09
d96b781 to
00c524b
Compare
Bojun-Vvibe
added a commit
to Bojun-Vvibe/oss-contributions
that referenced
this pull request
Apr 25, 2026
pakrym-oai
marked this pull request as ready for review
April 25, 2026 04:00
pakrym-oai
force-pushed
the
pakrym/appserver-errors-review-feedback
branch
from
April 25, 2026 04:10
00c524b to
cbd5761
Compare
pakrym-oai
force-pushed
the
pakrym/appserver-errors-turn-realtime
branch
2 times, most recently
from
April 25, 2026 04:15
5728267 to
5d14bae
Compare
pakrym-oai
force-pushed
the
pakrym/appserver-errors-review-feedback
branch
from
April 25, 2026 04:15
cbd5761 to
460ddfa
Compare
ningyi-oai
approved these changes
Apr 25, 2026
pakrym-oai
force-pushed
the
pakrym/appserver-errors-turn-realtime
branch
from
April 26, 2026 23:08
5d14bae to
cc036aa
Compare
pakrym-oai
force-pushed
the
pakrym/appserver-errors-review-feedback
branch
2 times, most recently
from
April 26, 2026 23:15
c4c9831 to
e66cdb9
Compare
pakrym-oai
force-pushed
the
pakrym/appserver-errors-turn-realtime
branch
from
April 26, 2026 23:15
cc036aa to
bd31008
Compare
pakrym-oai
force-pushed
the
pakrym/appserver-errors-review-feedback
branch
from
April 27, 2026 17:22
e66cdb9 to
862b529
Compare
pakrym-oai
force-pushed
the
pakrym/appserver-errors-turn-realtime
branch
2 times, most recently
from
April 27, 2026 18:45
a39db7c to
8b59896
Compare
pakrym-oai
force-pushed
the
pakrym/appserver-errors-review-feedback
branch
2 times, most recently
from
April 27, 2026 20:38
1db7482 to
a5c7757
Compare
pakrym-oai
force-pushed
the
pakrym/appserver-errors-turn-realtime
branch
from
April 27, 2026 20:38
8b59896 to
13a8275
Compare
pakrym-oai
force-pushed
the
pakrym/appserver-errors-review-feedback
branch
from
April 27, 2026 21:01
a5c7757 to
cf8dcc6
Compare
pakrym-oai
force-pushed
the
pakrym/appserver-errors-turn-realtime
branch
from
April 27, 2026 21:01
13a8275 to
e48222a
Compare
pakrym-oai
force-pushed
the
pakrym/appserver-errors-review-feedback
branch
from
April 27, 2026 21:19
cf8dcc6 to
f9608a3
Compare
pakrym-oai
force-pushed
the
pakrym/appserver-errors-turn-realtime
branch
2 times, most recently
from
April 27, 2026 21:31
74eaf21 to
47b736e
Compare
pakrym-oai
force-pushed
the
pakrym/appserver-errors-review-feedback
branch
from
April 27, 2026 21:31
f9608a3 to
a01e530
Compare
pakrym-oai
force-pushed
the
pakrym/appserver-errors-turn-realtime
branch
from
April 27, 2026 22:05
47b736e to
ce5a9ce
Compare
pakrym-oai
force-pushed
the
pakrym/appserver-errors-review-feedback
branch
from
April 27, 2026 22:05
a01e530 to
a29cb5f
Compare
pakrym-oai
force-pushed
the
pakrym/appserver-errors-review-feedback
branch
from
April 27, 2026 22:22
a29cb5f to
7a79b46
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The remaining review, interrupt, fuzzy search, feedback, and git-diff handlers still had local send-error branches that obscured otherwise simple request handling. This final slice flattens those handlers without changing the public protocol behavior.
What Changed
codex-rs/app-server/src/codex_message_processor.rs.send_error/returnblocks.Verification
cargo check -p codex-app-servercargo test -p codex-app-server --test all v2::review -- --test-threads=1