Skip to content

Move metadata calculation out of client #10589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pakrym-oai merged 6 commits into from
Feb 4, 2026
Merged

Move metadata calculation out of client #10589

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d195313
Move metadata calculation out of client
pakrym-oai Feb 4, 2026
e3927b7
Pass turn metadata through compaction session
pakrym-oai Feb 4, 2026
3d9625c
core: use test_codex in turn metadata header e2e test
pakrym-oai Feb 4, 2026
7abb3fb
codex: add timeout to turn metadata header resolution
pakrym-oai Feb 4, 2026
e866e98
codex: update turn metadata timeout log to 250ms
pakrym-oai Feb 4, 2026
f104fa3
core: avoid unnecessary cwd clone in TurnContext construction
pakrym-oai Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
codex: add timeout to turn metadata header resolution
  • Loading branch information
@pakrym-oai
pakrym-oai committed Feb 4, 2026
commit 7abb3fb189b8bd28e72f409e024fd66c385ce3e4
20 changes: 18 additions & 2 deletions codex-rs/core/src/codex.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -519,18 +519,34 @@ impl TurnContext {
.unwrap_or(compact::SUMMARIZATION_PROMPT)
}

pub(crate) async fn resolve_turn_metadata_header(&self) -> Option<String> {
async fn build_turn_metadata_header(&self) -> Option<String> {
self.turn_metadata_header
.get_or_init(|| async { build_turn_metadata_header(self.cwd.as_path()).await })
.await
.clone()
}

pub async fn resolve_turn_metadata_header(&self) -> Option<String> {
const TURN_METADATA_HEADER_TIMEOUT_MS: u64 = 250;
match tokio::time::timeout(
std::time::Duration::from_millis(TURN_METADATA_HEADER_TIMEOUT_MS),
self.build_turn_metadata_header(),
)
.await
{
Ok(header) => header,
Err(_) => {
warn!("timed out after 500ms while building turn metadata header");
self.turn_metadata_header.get().cloned().flatten()
}
}
}

pub fn spawn_turn_metadata_header_task(self: &Arc<Self>) {
let context = Arc::clone(self);
tokio::spawn(async move {
trace!("Spawning turn metadata calculation task");
context.resolve_turn_metadata_header().await;
context.build_turn_metadata_header().await;
trace!("Turn metadata calculation task completed");
});
}
Expand Down
Loading