Repository navigation
Conversation
Generated with:
git ls-files '*.go' | xargs gofmt -l | xargs gofmt -w
Co-Authored-By: Claude Opus 5.5 <[email protected]>
`make lint` runs golangci-lint, so enabling its gofmt formatter makes CI fail on unformatted code. The linters stay at golangci-lint's defaults. Closes oapi-codegen#2409 Co-Authored-By: Claude Opus 5.5 <[email protected]>
eyoshioka
marked this pull request as ready for review
October 8, 2026 10:40
Contributor
 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2409.
As proposed in my comment, this enables golangci-lint's gofmt formatter, so
make lint, and therefore CI, fails on unformatted code. The enabled linters stay at golangci-lint's defaults.gofmt -won the 11 files that currently fail. Apart from an import order inpkg/codegen/utils.go, the changes are whitespace only..golangci.yml.With the new config,
make lintfails on the currentmainand passes with the first commit in every module. If you'd rather add the check tooapi-codegen/actions, I'll drop the second commit.