Skip to content

feat(ProxyAgent) improve Curl-y behavior in HTTP->HTTP Proxy connections (#4180) #4340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcollina merged 3 commits into from
Jul 24, 2025
Merged

feat(ProxyAgent) improve Curl-y behavior in HTTP->HTTP Proxy connections (#4180) #4340

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0180741
feat(ProxyAgent) improve Curl-y behavior in HTTP->HTTP Proxy connecti…
caitp Jul 10, 2025
f863865
add a test to attempt multiple concurrent connections with a single H…
caitp Jul 22, 2025
8881567
be explicit about proxyTunnel status in each ProxyAgent test
caitp Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add a test to attempt multiple concurrent connections with a single H… 
…ttpContext
  • Loading branch information
@caitp
caitp committed Jul 23, 2025
commit f863865f1efe8ad2d3f51316fa7a265939572b56
42 changes: 42 additions & 0 deletions test/proxy-agent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1290,6 +1290,48 @@ test('ProxyAgent keeps customized host in request headers - #3019', async (t) =>
proxyAgent.close()
})

test('ProxyAgent handles multiple concurrent HTTP requests via HTTP proxy', async (t) => {
t = tspl(t, { plan: 20 })
// Start target HTTP server
const server = createServer((req, res) => {
setTimeout(() => {
res.setHeader('content-type', 'application/json')
res.end(JSON.stringify({ url: req.url }))
}, 50)
})
await new Promise(resolve => server.listen(0, resolve))
const targetPort = server.address().port

// Start HTTP proxy server
const proxy = createProxy(createServer())
await new Promise(resolve => proxy.listen(0, resolve))
const proxyPort = proxy.address().port

// Create ProxyAgent (no tunneling, plain HTTP)
const proxyAgent = new ProxyAgent(`http://localhost:${proxyPort}`)

const N = 10
const requests = []
for (let i = 0; i < N; i++) {
requests.push(
request(`http://localhost:${targetPort}/test${i}`, { dispatcher: proxyAgent })
.then(async res => {
t.strictEqual(res.statusCode, 200)
const json = await res.body.json()
t.deepStrictEqual(json, { url: `/test${i}` })
})
)
}
try {
await Promise.all(requests)
} catch (err) {
t.fail(err)
}
server.close()
proxy.close()
proxyAgent.close()
})

function buildServer () {
return new Promise((resolve) => {
const server = createServer({ joinDuplicateHeaders: true })
Expand Down