fix: clean up console.logs and improve SnapshotAgent experimental war…

…ning - Remove spurious console.log statements from SnapshotAgent and related tests - Remove experimental warning from SnapshotRecorder constructor - Ensure SnapshotAgent experimental warning is only emitted once per process - Fix trailing whitespace in snapshot-recorder test 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> Signed-off-by: Matteo Collina <[email protected]>
mcollina · Jul 31, 2025 · Jun 8, 2025 · Jul 19, 2025 · Jul 19, 2025 · Jul 19, 2025
commit a9d7cb7c8f15dd7b0d325a85859cb506b67a02e4
diff --git a/lib/mock/snapshot-agent.js b/lib/mock/snapshot-agent.js
@@ -12,13 +12,19 @@ const kSnapshotPath = Symbol('kSnapshotPath')
 const kSnapshotLoaded = Symbol('kSnapshotLoaded')
 const kRealAgent = Symbol('kRealAgent')
 
+// Static flag to ensure warning is only emitted once
+let warningEmitted = false
+
 class SnapshotAgent extends MockAgent {
   constructor (opts = {}) {
-    // Emit experimental warning
-    process.emitWarning(
-      'SnapshotAgent is experimental and subject to change',
-      'ExperimentalWarning'
-    )
+    // Emit experimental warning only once
+    if (!warningEmitted) {
+      process.emitWarning(
+        'SnapshotAgent is experimental and subject to change',
+        'ExperimentalWarning'
+      )
+      warningEmitted = true
+    }
 
     const mockOptions = { ...opts }
     delete mockOptions.mode
@@ -131,7 +137,6 @@ class SnapshotAgent extends MockAgent {
 
     const recordingHandler = {
       onRequestStart (controller, context) {
-        console.log('aaa')
         return handler.onRequestStart(controller, { ...context, history: this.history })
       },
 
@@ -140,7 +145,6 @@ class SnapshotAgent extends MockAgent {
       },
 
       onResponseStart (controller, statusCode, headers, statusMessage) {
-        console.log('onResponseStart', arguments)
         responseData.statusCode = statusCode
         responseData.headers = headers
         return handler.onResponseStart(controller, statusCode, headers, statusMessage)
@@ -152,7 +156,6 @@ class SnapshotAgent extends MockAgent {
       },
 
       onResponseEnd (controller, trailers) {
-        console.log('onResponseEnd')
         responseData.trailers = trailers
 
         // Record the interaction using captured 'self' context (fire and forget)

diff --git a/lib/mock/snapshot-recorder.js b/lib/mock/snapshot-recorder.js
@@ -173,12 +173,6 @@ function isUrlExcluded (url, excludePatterns = []) {
 
 class SnapshotRecorder {
   constructor (options = {}) {
-    // Emit experimental warning
-    process.emitWarning(
-      'SnapshotRecorder is experimental and subject to change',
-      'ExperimentalWarning'
-    )
-
     this.snapshots = new Map()
     this.snapshotPath = options.snapshotPath
     this.mode = options.mode || 'record'

diff --git a/test/snapshot-recorder.js b/test/snapshot-recorder.js
@@ -415,7 +415,7 @@ test('SnapshotRecorder - redirect responses are stored correctly', (t) => {
   snapshot = recorder.findSnapshot(redirectRequestOpts)
   assert(snapshot, 'Should find snapshot for redirect request')
   assert.strictEqual(snapshot.request.url, 'https://api.example.com/redirect-start')
-  
+
   // The recorder supports sequential responses, so it should have both
   assert(Array.isArray(snapshot.responses), 'Should have responses array')
   assert.strictEqual(snapshot.responses.length, 2, 'Should have two responses')

diff --git a/test/snapshot-testing.js b/test/snapshot-testing.js
@@ -25,7 +25,6 @@ test('SnapshotAgent - record mode', async (t) => {
   const origin = `http://localhost:${port}`
 
   t.after(() => new Promise((resolve, reject) => {
-    console.log('closing')
     server.close((err) => {
       if (err) {
         reject(err)
@@ -67,8 +66,6 @@ test('SnapshotAgent - record mode', async (t) => {
   assert.strictEqual(snapshots[0].request.url, `${origin}/test`)
   assert.strictEqual(snapshots[0].responses[0].statusCode, 200)
 
-  console.log('bbb')
-
   // Cleanup
   t.after(() => unlink(snapshotPath))
 })
@@ -1241,4 +1238,3 @@ test('SnapshotAgent - complex filtering scenarios', async (t) => {
   // Cleanup
   t.after(() => unlink(snapshotPath).catch(() => {}))
 })
-