Skip to content

Extract webidl #4259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Uzlopak merged 8 commits into from
Jun 4, 2025
Merged

Extract webidl #4259

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1230450
chore: extract webidl from fetch folder
Uzlopak Jun 3, 2025
1e3dd0f
fix import in benchmark
Uzlopak Jun 3, 2025
1f84ab8
move benchmark
Uzlopak Jun 3, 2025
b1e0fea
fix benchmark
Uzlopak Jun 3, 2025
e4ae67d
improve errors
Uzlopak Jun 3, 2025
d24dfc5
move USVString functions to webidl
Uzlopak Jun 3, 2025
18362fc
improve webidl.util.Stringify
Uzlopak Jun 3, 2025
48a3a3f
add tests for webidl.converters.boolean
Uzlopak Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add tests for webidl.converters.boolean
  • Loading branch information
@Uzlopak
Uzlopak committed Jun 3, 2025
commit 48a3a3f58fbb32feb8a0826806fffd89c0807456
1 change: 1 addition & 0 deletions lib/web/webidl/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -593,6 +593,7 @@ webidl.converters.USVString = (() => {
// https://webidl.spec.whatwg.org/#es-boolean
webidl.converters.boolean = function (V) {
// 1. Let x be the result of computing ToBoolean(V).
// https://262.ecma-international.org/10.0/index.html#table-10
const x = Boolean(V)

// 2. Return the IDL boolean value that is the one that represents
Expand Down
31 changes: 31 additions & 0 deletions test/webidl/converters.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,3 +224,34 @@ test('recordConverter', () => {
new TypeError('prefix: argument ("Null") is not an Object.')
)
})

test('webidl.converters.boolean', () => {
assert.strictEqual(webidl.converters.boolean(null), false)
assert.strictEqual(webidl.converters.boolean(undefined), false)

assert.strictEqual(webidl.converters.boolean(true), true)
assert.strictEqual(webidl.converters.boolean(false), false)

assert.strictEqual(webidl.converters.boolean(''), false)
assert.strictEqual(webidl.converters.boolean('true'), true)
assert.strictEqual(webidl.converters.boolean('false'), true)

assert.strictEqual(webidl.converters.boolean(1), true)
assert.strictEqual(webidl.converters.boolean(0), false)
assert.strictEqual(webidl.converters.boolean(-0), false)
assert.strictEqual(webidl.converters.boolean(NaN), false)
assert.strictEqual(webidl.converters.boolean(Infinity), true)
assert.strictEqual(webidl.converters.boolean(-Infinity), true)

assert.strictEqual(webidl.converters.boolean(0n), false)
assert.strictEqual(webidl.converters.boolean(1n), true)

assert.strictEqual(webidl.converters.boolean({}), true)
assert.strictEqual(webidl.converters.boolean([]), true)
assert.strictEqual(webidl.converters.boolean(() => {}), true)
assert.strictEqual(webidl.converters.boolean(/a/), true)
assert.strictEqual(webidl.converters.boolean(new Date()), true)
assert.strictEqual(webidl.converters.boolean(new Map()), true)
assert.strictEqual(webidl.converters.boolean(new Set()), true)
assert.strictEqual(webidl.converters.boolean(new Date()), true)
})