Skip to content

fix: cache fixes #3871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ronag merged 8 commits into from
Nov 23, 2024
Merged

fix: cache fixes #3871

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
039945b
fix: cache fixes
ronag Nov 22, 2024
1c3db49
Update cache-interceptor.d.ts
ronag Nov 22, 2024
176950e
fixup
ronag Nov 23, 2024
af0f344
rfixupo
ronag Nov 23, 2024
218a988
fixup
ronag Nov 23, 2024
244f20d
fixup
ronag Nov 23, 2024
59bcb75
fixup
ronag Nov 23, 2024
b9d0d13
fixup
ronag Nov 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rfixupo
  • Loading branch information
@ronag
ronag committed Nov 23, 2024
commit af0f34423fea5d13c8346a9791df0839e5b833a2
7 changes: 1 addition & 6 deletions lib/cache/sqlite-cache-store.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ class SqliteCacheStore {
const body = []
const store = this

const writable = new Writable({
return new Writable({
write (chunk, encoding, callback) {
if (typeof chunk === 'string') {
chunk = Buffer.from(chunk, encoding)
Expand All @@ -265,9 +265,6 @@ class SqliteCacheStore {
final (callback) {
store.prune()

/**
* @type {SqliteStoreValue | undefined}
*/
const existingValue = store.#findValue(key, true)
if (existingValue) {
// Updating an existing response, let's overwrite it
Expand Down Expand Up @@ -304,8 +301,6 @@ class SqliteCacheStore {
callback()
}
})

return writable
}

/**
Expand Down