Skip to content

separate whatwg websocket logic from rfc 6455 #3396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KhafraDev merged 5 commits into from
Jul 8, 2024
Merged

separate whatwg websocket logic from rfc 6455 #3396

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
de89fde
separate whatwg websocket logic from rfc 6455
KhafraDev Jul 7, 2024
50dbc88
fixup
KhafraDev Jul 7, 2024
7c8d958
remove symbols
KhafraDev Jul 7, 2024
88610a1
move parser events
KhafraDev Jul 7, 2024
b729538
remove symbols
KhafraDev Jul 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup
  • Loading branch information
@KhafraDev
KhafraDev committed Jul 7, 2024
commit 50dbc885bef37f63486639483a76fef7bece0381
6 changes: 3 additions & 3 deletions lib/web/websocket/websocket.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,7 +455,7 @@ class WebSocket extends EventTarget {
this[kResponse] = response

const parser = new ByteParser(this, this.#handler, parsedExtensions)
parser.on('drain', onParserDrain.bind(this[kResponse].socket))
parser.on('drain', onParserDrain)
parser.on('error', onParserError.bind(this, this.#handler))

response.socket.ws = this
Expand Down Expand Up @@ -703,8 +703,8 @@ webidl.converters.WebSocketSendData = function (V) {
return webidl.converters.USVString(V)
}

function onParserDrain (socket) {
socket.resume()
function onParserDrain () {
this.ws[kResponse].socket.resume()
}

function onParserError (handler, err) {
Expand Down