Skip to content

stream: reduce webstreams encoding and iteration overhead #65414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 3 commits into from
Aug 24, 2026
+166 −35
Merged

stream: reduce webstreams encoding and iteration overhead #65414

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3650132
stream: encode whole chunks in TextEncoderStream
mcollina Aug 20, 2026
c8e5339
stream: avoid async pull machinery in ReadableStream.from
mcollina Aug 20, 2026
06951a7
stream: use a Symbol for kParkedAlgorithmResult
mcollina Aug 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
stream: use a Symbol for kParkedAlgorithmResult 
The parked-result sentinel is only ever compared by identity, so a
Symbol describes its purpose better than an empty null-prototype
object.

Signed-off-by: Matteo Collina <[email protected]>
  • Loading branch information
@mcollina
mcollina committed Aug 22, 2026
commit 06951a7347163e2c6be2dac559934cd77ef1a2c0
2 changes: 1 addition & 1 deletion lib/internal/webstreams/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,7 @@ const kResolvedPromise = PromiseResolve();
// operation and takes responsibility for delivering the fulfilled (or
// rejected) continuation itself later, instead of settling a promise
// (see the transform stream source pull algorithm).
const kParkedAlgorithmResult = { __proto__: null };
const kParkedAlgorithmResult = Symbol('kParkedAlgorithmResult');

// Wires the (possibly non-thenable) result of an underlying algorithm
// callback to its fulfilled/rejected continuations. A non-thenable result
Expand Down
Loading