Skip to content

test: unflake debugger and REPL tests #64718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Aug 3, 2026
+64 −20
Merged

test: unflake debugger and REPL tests #64718

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd871fa
test: unflake debugger and REPL tests
mcollina Jul 25, 2026
9e4ff2c
test: harden debugger prompt test
mcollina Jul 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: harden debugger prompt test 
Use a long-lived debugger target and assert that the prompt is received
before sending the exit command.

Handle child exit and timeout failures explicitly instead of leaving the
test hanging when startup does not produce a prompt.

Signed-off-by: Matteo Collina <[email protected]>
  • Loading branch information
@mcollina
mcollina committed Jul 26, 2026
commit 9e4ff2c2518aac8aeacef7a86a66dcb12ee863d1
46 changes: 37 additions & 9 deletions test/sequential/test-debug-prompt.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,45 @@

const common = require('../common');
common.skipIfInspectorDisabled();
const assert = require('assert');
const fixtures = require('../common/fixtures');
const spawn = require('child_process').spawn;

const proc = spawn(process.execPath, ['inspect', 'foo']);
const proc = spawn(process.execPath, [
'inspect', fixtures.path('debugger', 'alive.js'),
]);
proc.stdout.setEncoding('utf8');

let needToSendExit = true;
const TIMEOUT = common.platformTimeout(10_000);
let output = '';
proc.stdout.on('data', (data) => {
output += data;
if (output.includes('debug> ') && needToSendExit) {
proc.stdin.write('.exit\n');
needToSendExit = false;
}
});
let promptSeen = false;

(async () => {
await new Promise((resolve, reject) => {
const timer = setTimeout(() => {
proc.kill();
reject(new Error(`Timed out waiting for the debugger prompt; output: ${output}`));
}, TIMEOUT);

proc.stdout.on('data', (data) => {
output += data;
if (output.includes('debug> ') && !promptSeen) {
promptSeen = true;
proc.stdin.end('.exit\n');
}
});

proc.once('error', reject);
proc.once('close', common.mustCall((code, signal) => {
clearTimeout(timer);
if (!promptSeen) {
reject(new Error(
`Debugger exited before showing the prompt (code ${code}, signal ${signal}); ` +
`output: ${output}`));
return;
}
assert.strictEqual(code, 0);
resolve();
}));
});
})().then(common.mustCall());
Loading