Skip to content

quic: make multiple improvements to packet #62589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jasnell wants to merge 4 commits into from
Closed

quic: make multiple improvements to packet #62589

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1af1795
quic: use arena allocation for packets
jasnell Apr 4, 2026
1bf0dc4
quic: improve packet definition
jasnell Apr 4, 2026
da1e78a
quic: fixup formatting after changes
jasnell Apr 4, 2026
58cb073
src: remove QUIC_PACKET from AsyncWrap::Type enum
jasnell Apr 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
quic: fixup formatting after changes 
Signed-off-by: James M Snell <[email protected]>
  • Loading branch information
@jasnell
jasnell committed Apr 4, 2026
commit da1e78af6c17da4b8c8665e010b4c19d8e0a3f42
6 changes: 3 additions & 3 deletions src/quic/endpoint.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ bool is_diagnostic_packet_loss(double probability) {
return (static_cast<double>(c) / 255) < probability;
}

template <typename Opt, double Opt::* member>
template <typename Opt, double Opt::*member>
bool SetOption(Environment* env,
Opt* options,
const Local<Object>& object,
Expand All @@ -112,7 +112,7 @@ bool SetOption(Environment* env,
}
#endif // DEBUG

template <typename Opt, uint8_t Opt::* member>
template <typename Opt, uint8_t Opt::*member>
bool SetOption(Environment* env,
Opt* options,
const Local<Object>& object,
Expand All @@ -139,7 +139,7 @@ bool SetOption(Environment* env,
return true;
}

template <typename Opt, TokenSecret Opt::* member>
template <typename Opt, TokenSecret Opt::*member>
bool SetOption(Environment* env,
Opt* options,
const Local<Object>& object,
Expand Down
8 changes: 6 additions & 2 deletions src/quic/endpoint.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,9 +151,13 @@ class Endpoint final : public AsyncWrap, public Packet::Listener {
v8::Local<v8::Object> object,
const Endpoint::Options& options);

inline operator Packet::Listener*() { return this; }
inline operator Packet::Listener*() {
return this;
}

inline const Options& options() const { return options_; }
inline const Options& options() const {
return options_;
}

// While the busy flag is set, the Endpoint will reject all initial packets
// with a SERVER_BUSY response. This allows us to build a circuit breaker
Expand Down
8 changes: 6 additions & 2 deletions src/quic/packet.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,12 @@ class Packet final {

// --- Diagnostic label: zero cost in release builds ---
#ifdef DEBUG
void set_diagnostic_label(const char* label) { diagnostic_label_ = label; }
const char* diagnostic_label() const { return diagnostic_label_; }
void set_diagnostic_label(const char* label) {
diagnostic_label_ = label;
}
const char* diagnostic_label() const {
return diagnostic_label_;
}
#else
void set_diagnostic_label(const char*) {}
#endif
Expand Down
10 changes: 5 additions & 5 deletions src/quic/session.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ void ngtcp2_debug_log(void* user_data, const char* fmt, ...) {
va_end(ap);
}

template <typename Opt, PreferredAddress::Policy Opt::* member>
template <typename Opt, PreferredAddress::Policy Opt::*member>
bool SetOption(Environment* env,
Opt* options,
const Local<Object>& object,
Expand All @@ -222,7 +222,7 @@ bool SetOption(Environment* env,
return true;
}

template <typename Opt, TLSContext::Options Opt::* member>
template <typename Opt, TLSContext::Options Opt::*member>
bool SetOption(Environment* env,
Opt* options,
const Local<Object>& object,
Expand All @@ -237,7 +237,7 @@ bool SetOption(Environment* env,
return true;
}

template <typename Opt, TransportParams::Options Opt::* member>
template <typename Opt, TransportParams::Options Opt::*member>
bool SetOption(Environment* env,
Opt* options,
const Local<Object>& object,
Expand All @@ -253,7 +253,7 @@ bool SetOption(Environment* env,
}

template <typename Opt,
BaseObjectPtr<Session::ApplicationProvider> Opt::* member>
BaseObjectPtr<Session::ApplicationProvider> Opt::*member>
bool SetOption(Environment* env,
Opt* options,
const Local<Object>& object,
Expand All @@ -279,7 +279,7 @@ bool SetOption(Environment* env,
return true;
}

template <typename Opt, ngtcp2_cc_algo Opt::* member>
template <typename Opt, ngtcp2_cc_algo Opt::*member>
bool SetOption(Environment* env,
Opt* options,
const Local<Object>& object,
Expand Down
Loading