Same issue here. ``` CC(target) Release/obj.target/libssh2/vendor/libssh2/src/knownhost.o CC(target) Release/obj.target/libssh2/vendor/libssh2/src/misc.o CC(target) Release/obj.target/libssh2/vendor/libssh2/src/pem.o CC(target) Release/obj.target/libssh2/vendor/libssh2/src/session.o CC(target) Release/obj.target/libssh2/vendor/libssh2/src/userauth.o LIBTOOL-STATIC Release/ssh2.a CXX(target) Release/obj.target/nodegit/src/async_baton.o CXX(target) Release/obj.target/nodegit/src/lock_master.o CXX(target) Release/obj.target/nodegit/src/reference_counter.o CXX(target) Release/obj.target/nodegit/src/nodegit.o ../src/nodegit.cc:195:43: warning: 'ToInt32' is deprecated: Use maybe version [-Wdeprecated-declarations] v8::Local value = info[0]->ToInt32(v8::Isolate::GetCurrent()); ^ /Users/me/.node-gyp/12.5.0/include/node/v8.h:2549:3: note: 'ToInt32' has been explicitly marked deprecated here V8_DEPRECATED("Use maybe version", ^ /Users/me/.node-gyp/12.5.0/include/node/v8config.h:311:29: note: expanded from macro 'V8_DEPRECATED' declarator __attribute__((deprecated(message))) ^ ../src/nodegit.cc:216:11: warning: 'Set' is deprecated: Use maybe version [-Wdeprecated-declarations] result->Set(Nan::New("storedMutexesCount").ToLocalChecked(), Nan::New(diagnostics.storedMutexesCount)); ^ /Users/me/.node-gyp/12.5.0/include/node/v8.h:3358:3: note: 'Set' has been explicitly marked deprecated here V8_DEPRECATE_SOON("Use maybe version", ^ /Users/me/.node-gyp/12.5.0/include/node/v8config.h:326:29: note: expanded from macro 'V8_DEPRECATE_SOON' declarator __attribute__((deprecated(message))) ^ ../src/nodegit.cc:394:17: warning: 'Set' is deprecated: Use maybe version [-Wdeprecated-declarations] threadSafety->Set(Nan::New("DISABLED").ToLocalChecked(), Nan::New((int)LockMaster::Disabled)); ^ /Users/me/.node-gyp/12.5.0/include/node/v8.h:3358:3: note: 'Set' has been explicitly marked deprecated here V8_DEPRECATE_SOON("Use maybe version", ^ /Users/me/.node-gyp/12.5.0/include/node/v8config.h:326:29: note: expanded from macro 'V8_DEPRECATE_SOON' declarator __attribute__((deprecated(message))) ^ ../src/nodegit.cc:395:17: warning: 'Set' is deprecated: Use maybe version [-Wdeprecated-declarations] threadSafety->Set(Nan::New("ENABLED_FOR_ASYNC_ONLY").ToLocalChecked(), Nan::New((int)LockMaster::EnabledForAsyncOnly)); ^ /Users/me/.node-gyp/12.5.0/include/node/v8.h:3358:3: note: 'Set' has been explicitly marked deprecated here V8_DEPRECATE_SOON("Use maybe version", ^ /Users/me/.node-gyp/12.5.0/include/node/v8config.h:326:29: note: expanded from macro 'V8_DEPRECATE_SOON' declarator __attribute__((deprecated(message))) ^ ../src/nodegit.cc:396:17: warning: 'Set' is deprecated: Use maybe version [-Wdeprecated-declarations] threadSafety->Set(Nan::New("ENABLED").ToLocalChecked(), Nan::New((int)LockMaster::Enabled)); ^ /Users/me/.node-gyp/12.5.0/include/node/v8.h:3358:3: note: 'Set' has been explicitly marked deprecated here V8_DEPRECATE_SOON("Use maybe version", ^ /Users/me/.node-gyp/12.5.0/include/node/v8config.h:326:29: note: expanded from macro 'V8_DEPRECATE_SOON' declarator __attribute__((deprecated(message))) ^ ../src/nodegit.cc:398:11: warning: 'Set' is deprecated: Use maybe version [-Wdeprecated-declarations] target->Set(Nan::New("THREAD_SAFETY").ToLocalChecked(), threadSafety); ^ /Users/me/.node-gyp/12.5.0/include/node/v8.h:3358:3: note: 'Set' has been explicitly marked deprecated here V8_DEPRECATE_SOON("Use maybe version", ^ /Users/me/.node-gyp/12.5.0/include/node/v8config.h:326:29: note: expanded from macro 'V8_DEPRECATE_SOON' declarator __attribute__((deprecated(message))) ^ 6 warnings generated. CXX(target) Release/obj.target/nodegit/src/init_ssh2.o CXX(target) Release/obj.target/nodegit/src/promise_completion.o ../src/promise_completion.cc:12:40: error: too few arguments to function call, single argument 'context' was not specified newFn.Reset(newTemplate->GetFunction()); ~~~~~~~~~~~~~~~~~~~~~~~~ ^ /Users/me/.node-gyp/12.5.0/include/node/v8.h:5948:3: note: 'GetFunction' declared here V8_WARN_UNUSED_RESULT MaybeLocal GetFunction( ^ /Users/me/.node-gyp/12.5.0/include/node/v8config.h:351:31: note: expanded from macro 'V8_WARN_UNUSED_RESULT' #define V8_WARN_UNUSED_RESULT __attribute__((warn_unused_result)) ^ ../src/promise_completion.cc:14:88: error: too few arguments to function call, single argument 'context' was not specified promiseFulfilled.Reset(Nan::New(PromiseFulfilled)->GetFunction()); ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ /Users/me/.node-gyp/12.5.0/include/node/v8.h:5948:3: note: 'GetFunction' declared here V8_WARN_UNUSED_RESULT MaybeLocal GetFunction( ^ /Users/me/.node-gyp/12.5.0/include/node/v8config.h:351:31: note: expanded from macro 'V8_WARN_UNUSED_RESULT' #define V8_WARN_UNUSED_RESULT __attribute__((warn_unused_result)) ^ ../src/promise_completion.cc:15:86: error: too few arguments to function call, single argument 'context' was not specified promiseRejected.Reset(Nan::New(PromiseRejected)->GetFunction()); ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ /Users/me/.node-gyp/12.5.0/include/node/v8.h:5948:3: note: 'GetFunction' declared here V8_WARN_UNUSED_RESULT MaybeLocal GetFunction( ^ /Users/me/.node-gyp/12.5.0/include/node/v8config.h:351:31: note: expanded from macro 'V8_WARN_UNUSED_RESULT' #define V8_WARN_UNUSED_RESULT __attribute__((warn_unused_result)) ^ ../src/promise_completion.cc:24:65: error: no matching member function for call to 'ToObject' Nan::MaybeLocal maybeThenProp = Nan::Get(result->ToObject(), Nan::New("then").ToLocalChecked()); ~~~~~~~~^~~~~~~~ /Users/me/.node-gyp/12.5.0/include/node/v8.h:2532:44: note: candidate function not viable: requires single argument 'context', but no arguments were provided V8_WARN_UNUSED_RESULT MaybeLocal

Uh oh!

Need to implement support for node 12 #1680

Description

Activity

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions