You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The property one was easy enough, although I'd prefer to use an hypothetical is_property attribute in the Griffe object. The exception one will have to wait as there's no easy way to check that a class inherits (directly or indirectly) from Exception or BaseException. This will need an update in Griffe (adding for example an is_exception property on class objects). The method one was trivial.
I didn't add support for classmethod and staticmethod, seeing how little they are used in the wild anyway.
Finally I kept parameter and typeparameter, although they are invalid, since some Sphinx extensions already take the liberty to use parameter. We're just a bit more consistent now. If this really is problematic (do some inventory loaders enforce valid types?), we can use obj instead, I don't mind.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue-339: #339
For reviewers
Description of the change
See #339, Sphinx inventories do not contain "roles" but "object types".