[cmake-user] Test multi-config cmake usage by dg0yt · Pull Request #27408 · microsoft/vcpkg

Kai Pastor (dg0yt) · 2022-10-23T09:29:53Z

What does your PR fix?

Extends port cmake-user to cover usage with multi-config.
Confirms [giflib] Debug library linked in release configuration #26833. Validates [giflib] Fix multi-config find_package(GIF) #27369.
Which triplets are supported/not supported? Have you updated the CI baseline?

unchanged, no
Does your PR follow the maintainer guide?

yes
If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

I am still working on this PR.

Kai Pastor (dg0yt) · 2022-10-23T09:34:34Z

Example output,
buildtrees/cmake-user/x64-linux-3.24.0-find-package-ICU-release-out.log:

-- find_package(ICU) check: success
-- ICU_LIBRARIES: /home/dg0yt/vcpkg/installed/x64-linux/debug/lib/libicudata.a;/home/dg0yt/vcpkg/installed/x64-linux/debug/lib/libicudata.a
-- Configuring incomplete, errors occurred!

buildtrees/cmake-user/x64-linux-3.24.0-find-package-ICU-release-err.log:

CMake Error at CMakeLists.txt:103 (message):
  Unguarded debug lib during multi-config usage:
  /home/dg0yt/vcpkg/installed/x64-linux/debug/lib/libicudata.a


CMake Error at CMakeLists.txt:103 (message):
  Unguarded debug lib during multi-config usage:
  /home/dg0yt/vcpkg/installed/x64-linux/debug/lib/libicudata.a

Alexander Neumann (Neumann-A) · 2022-10-23T10:17:25Z

Multi config will always be a bit buggy because of vendored/custom Find<pkg>.cmake scripts which doesn't concern themselves with multi config at all. There is also no way to fix it since adding vcpkg-cmake-wrappers for all those custom scripts is not really and option. Furthermore FindPkgConfig itself doesn't work in multi config.

Kai Pastor (dg0yt) · 2022-10-23T12:07:55Z

Multi config will always be a bit buggy because of vendored/custom Find.cmake scripts which doesn't concern themselves with multi config at all.

I don't care much about vendored copies. All the tests in cmake-user are for Kitware's Find modules. Still, vcpkg gets the bug reports (cf. port giflib).

Results from CI, x64-windows release

-- Running tests with CMake 3.24.0 for 'release'
--   find_package(BZip2)
--   find_package(CURL)
--   find_package(EXPAT)
--   find_package(Fontconfig)
--   find_package(Freetype)
--   find_package(Intl)
CMake Error at scripts/test_ports/cmake-user/portfile.cmake:209 (message):
    CMake 3.24.0: configuration with `find_package(Intl)` failed.
    See logs for more information:
      D:/buildtrees/cmake-user/x64-windows-3.24.0-find-package-Intl-release-out.log
      D:/buildtrees/cmake-user/x64-windows-3.24.0-find-package-Intl-release-err.log

Call Stack (most recent call first):
  scripts/test_ports/cmake-user/portfile.cmake:232 (test_cmake_project)
  scripts/ports.cmake:147 (include)


--   find_package(GIF)
CMake Error at scripts/test_ports/cmake-user/portfile.cmake:209 (message):
    CMake 3.24.0: configuration with `find_package(GIF)` failed.
    See logs for more information:
      D:/buildtrees/cmake-user/x64-windows-3.24.0-find-package-GIF-release-out.log
      D:/buildtrees/cmake-user/x64-windows-3.24.0-find-package-GIF-release-err.log

Call Stack (most recent call first):
  scripts/test_ports/cmake-user/portfile.cmake:232 (test_cmake_project)
  scripts/ports.cmake:147 (include)


--   find_package(ICU)
--   find_package(Iconv)
CMake Error at scripts/test_ports/cmake-user/portfile.cmake:209 (message):
    CMake 3.24.0: configuration with `find_package(Iconv)` failed.
    See logs for more information:
      D:/buildtrees/cmake-user/x64-windows-3.24.0-find-package-Iconv-release-out.log
      D:/buildtrees/cmake-user/x64-windows-3.24.0-find-package-Iconv-release-err.log

Call Stack (most recent call first):
  scripts/test_ports/cmake-user/portfile.cmake:232 (test_cmake_project)
  scripts/ports.cmake:147 (include)


--   find_package(JPEG)
--   find_package(LibLZMA)
--   find_package(PNG)
--   find_package(PostgreSQL)
CMake Error at scripts/test_ports/cmake-user/portfile.cmake:209 (message):
    CMake 3.24.0: configuration with `find_package(PostgreSQL)` failed.
    See logs for more information:
      D:/buildtrees/cmake-user/x64-windows-3.24.0-find-package-PostgreSQL-release-out.log
      D:/buildtrees/cmake-user/x64-windows-3.24.0-find-package-PostgreSQL-release-err.log

Call Stack (most recent call first):
  scripts/test_ports/cmake-user/portfile.cmake:232 (test_cmake_project)
  scripts/ports.cmake:147 (include)


--   find_package(LibXml2)
CMake Error at scripts/test_ports/cmake-user/portfile.cmake:209 (message):
    CMake 3.24.0: configuration with `find_package(LibXml2)` failed.
    See logs for more information:
      D:/buildtrees/cmake-user/x64-windows-3.24.0-find-package-LibXml2-release-out.log
      D:/buildtrees/cmake-user/x64-windows-3.24.0-find-package-LibXml2-release-err.log

Call Stack (most recent call first):
  scripts/test_ports/cmake-user/portfile.cmake:232 (test_cmake_project)
  scripts/ports.cmake:147 (include)


--   find_package(LibXslt)
CMake Error at scripts/test_ports/cmake-user/portfile.cmake:209 (message):
    CMake 3.24.0: configuration with `find_package(LibXslt)` failed.
    See logs for more information:
      D:/buildtrees/cmake-user/x64-windows-3.24.0-find-package-LibXslt-release-out.log
      D:/buildtrees/cmake-user/x64-windows-3.24.0-find-package-LibXslt-release-err.log

Call Stack (most recent call first):
  scripts/test_ports/cmake-user/portfile.cmake:232 (test_cmake_project)
  scripts/ports.cmake:147 (include)


--   find_package(TIFF)
--   find_package(wxWidgets)
--   find_package(ZLIB)
--   find_package(ZLIBviaPkgConfig)

github-actions

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)
vcpkg_extract_source_archive_ex -> vcpkg_extract_source_archive
vcpkg_build_msbuild -> vcpkg_install_msbuild
vcpkg_copy_tool_dependencies -> vcpkg_copy_tools
vcpkg_apply_patches should be replaced by the PATCHES arguments to the "extract" helpers (e.g. vcpkg_from_github())

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

scripts/test_ports/cmake-user/portfile.cmake

Billy O'Neal (BillyONeal) · 2024-06-27T21:57:15Z

Closing this PR because it's been in draft without changes for more than a year. Please feel free to recreate or reopen!

Kai Pastor (dg0yt) · 2024-06-28T04:43:11Z

Cannot reopen...

Lily Wang (LilyWangLL) · 2024-06-28T06:07:01Z

Cannot reopen...

If you want to reopen this PR, please ping us anytime. Do you want to reopen this PR now?

Kai Pastor (dg0yt) · 2024-06-29T04:30:03Z

yes

Billy O'Neal (BillyONeal) · 2024-06-29T05:38:04Z

Hmm... reopening a PR shouldn't require permissions

Kai Pastor (dg0yt) · 2024-07-01T07:20:40Z

Hmm... reopening a PR shouldn't require permissions

It does, in this repo. And we are complaining almost every time.

Jonny (JonnyPtn) · 2026-10-01T12:52:15Z

 endif()

+message(STATUS "CMAKE_GENERATOR: ${CMAKE_GENERATOR}")
+if(CMAKE_GENERATOR MATCHES "Multi-Config|Visual Studio")


I've been hitting this issue with xcode, which I think this check would miss - Perhaps can use the GENERATOR_IS_MULTI_CONFIG property instead?

Makes sense.
(IIRC the actual problem with this PR was/is how many official Find modules did/do not support vcpkg's multiconfig installation layout.)

Changed. But the test port controls the generator, together with additional options.

Copilot

🟡 Changes recommended

Generator selection breaks CMake 3.16 tests, and the build arguments do not exercise the intended default-versus-active configuration mismatch.

2 open issues

What changed in this PR

Extends the cmake-user test port to check multi-configuration CMake usage, targeting configuration-specific library selection regressions such as #26833 and the fix in #27369.

Changes:

Selects Ninja Multi-Config for dual-configuration triplets and passes explicit configurations to package builds.
Adds generator diagnostics and checks for unguarded Debug or Release library paths.

Validation was limited to source inspection; no builds were run.

File	Description
scripts/test_ports/cmake-user/project/CMakeLists.txt	Adds configuration diagnostics and multi-config library checks.
scripts/test_ports/cmake-user/portfile.cmake	Selects generators and supplies configuration-specific build arguments.

_{Review effort: Balanced}

Kai Pastor (dg0yt) · 2026-10-25T10:18:27Z

Testing single-config for CMake 3.16 and for single-config (CI: x64-windows-release).

Considering MSVS and XCode as regular multi-config consumers.

For x64-windows multi-config, the failing packages are:

Fontconfig
Intl
LAPACK
Iconv
SQLite3

For arm64-osx multi-config, the failing packages are:

GnuTLS
Curses
SQLite3
wxWidgets

Test multi-config cmake usage

0998220

github-actions Bot previously approved these changes Oct 23, 2022

View reviewed changes

Kai Pastor (dg0yt) dismissed github-actions[bot]’s stale review via 0700676 October 23, 2022 12:49

github-actions Bot previously approved these changes Oct 23, 2022

View reviewed changes

Lily Wang (LilyWangLL) self-assigned this Oct 24, 2022

Lily Wang (LilyWangLL) added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Oct 24, 2022

Kai Pastor (dg0yt) added 2 commits November 5, 2022 06:25

Test SQLite3

d9a6a9b

Merge remote-tracking branch 'origin/master' into multi-config

f5dfa3b

Kai Pastor (dg0yt) dismissed github-actions[bot]’s stale review via f5dfa3b November 5, 2022 05:28

Kai Pastor (dg0yt) force-pushed the multi-config branch from 0700676 to f5dfa3b Compare November 5, 2022 05:28

github-actions Bot previously approved these changes Nov 5, 2022

View reviewed changes

Kai Pastor (dg0yt) mentioned this pull request Dec 7, 2022

[freetype] Fix cmake usage #28217

Merged

Kai Pastor (dg0yt) added 2 commits January 27, 2023 07:29

Format manifest

70f0c6c

Merge remote-tracking branch 'origin/master' into multi-config

9461c7a

Kai Pastor (dg0yt) dismissed github-actions[bot]’s stale review via 9461c7a January 27, 2023 06:35

github-actions Bot previously approved these changes Jan 27, 2023

View reviewed changes

Kai Pastor (dg0yt) mentioned this pull request Mar 3, 2023

[boost-modular-build-helper] [boost-uninstall] use system layout #23002

Closed

Kai Pastor (dg0yt) mentioned this pull request Apr 21, 2023

[openssl] wrongly picking debug versions for release config in Ninja Multi-Config generator #30969

Closed

Merge branch 'microsoft:master' into multi-config

199ec7b

Kai Pastor (dg0yt) mentioned this pull request May 27, 2023

[sqlite3] Provide cmake target SQLite::SQLite3 #31659

Closed

Billy O'Neal (BillyONeal) closed this Jun 27, 2024

Merge branch 'microsoft:master' into multi-config

9dec70c

Billy O'Neal (BillyONeal) reopened this Jun 29, 2024

Billy O'Neal (BillyONeal) dismissed github-actions[bot]’s stale review via 9dec70c June 29, 2024 05:37

Kai Pastor (dg0yt) mentioned this pull request Sep 12, 2024

Provide a way to get the debug/release library path for Nina Multi-Config builds when using CMake #21870

Closed

Kai Pastor (dg0yt) mentioned this pull request Nov 7, 2024

[sqlite3] Add wrapper to provide target SQLite::SQLite3 #41970

Closed

3 of 7 tasks

Kai Pastor (dg0yt) mentioned this pull request May 4, 2025

[hunspell] Unable to consume with multi-config generators #45343

Closed

Victor Romero (vicroms) added the no-stale Issue will not be marked as stale label Feb 12, 2026

Jonny (JonnyPtn) reviewed Oct 1, 2026

View reviewed changes

Kai Pastor (dg0yt) added 2 commits October 22, 2026 00:49

Convert to LF

1d0705f

Merge remote-tracking branch 'origin/master' into multi-config

89c6879

Copilot AI balanced review requested due to automatic review settings October 21, 2026 23:05

Copilot started reviewing on behalf of Kai Pastor (dg0yt) October 21, 2026 23:05

View session

Copilot AI reviewed Oct 21, 2026

View reviewed changes

Comment thread scripts/test_ports/cmake-user/portfile.cmake Outdated

Comment thread scripts/test_ports/cmake-user/portfile.cmake Outdated

WIP

8a85676

Kai Pastor (dg0yt) added 2 commits October 25, 2026 12:47

WIP

e079650

WIP

8b57f3f

Conversation

Kai Pastor (dg0yt) commented Oct 23, 2022

What does your PR fix?

Which triplets are supported/not supported? Have you updated the CI baseline?

Does your PR follow the maintainer guide?

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Uh oh!

Kai Pastor (dg0yt) commented Oct 23, 2022

Uh oh!

Alexander Neumann (Neumann-A) commented Oct 23, 2022

Uh oh!

Kai Pastor (dg0yt) commented Oct 23, 2022

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Billy O'Neal (BillyONeal) commented Jun 27, 2024

Uh oh!

Kai Pastor (dg0yt) commented Jun 28, 2024

Uh oh!

Lily Wang (LilyWangLL) commented Jun 28, 2024

Uh oh!

Kai Pastor (dg0yt) commented Jun 29, 2024

Uh oh!

Billy O'Neal (BillyONeal) commented Jun 29, 2024

Uh oh!

Kai Pastor (dg0yt) commented Jul 1, 2024

Uh oh!

Jonny (JonnyPtn) Oct 1, 2026

Choose a reason for hiding this comment

Uh oh!

Kai Pastor (dg0yt) Oct 2, 2026

Choose a reason for hiding this comment

Uh oh!

Kai Pastor (dg0yt) Oct 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Kai Pastor (dg0yt) commented Oct 25, 2026

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

If you have added/updated a port: Have you run `./vcpkg x-add-version --all` and committed the result?