Repository navigation
fix(agent-sre): return in-memory measurements in timestamp order - #4209
MohammadHaroonAbuomar merged 1 commit into
Conversation
Signed-off-by: Naveen Chatlapalli <[email protected]>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
🟡 Contributor Check: MEDIUM
Automated check by AGT Contributor Check. |
PR Review Summary
Verdict: AI review comments are untrusted advisory output. The summary reports workflow-generated completion status only, not model-authored pass/fail claims. |
|
Verified in code and locally: the in-memory store returned insertion order while SQLite returned timestamp order; the stable sort fixes it and keeps append order for equal timestamps. Sign-off is present and CI is approved and running. Before I approve, two process items that apply to all nine PRs in this batch: please use the repository template with its Checklist, Attribution, AI Assistance and IP sections, and tick the attestations in your own words. The AI note says Codex prepared and submitted the changes at your request; CONTRIBUTING asks that no PR be submitted by an agent without a human reviewing the specific changes, so one sentence confirming you reviewed this diff before it was opened settles it. Once that and the gated checks are green I will approve and merge. |
|
I reviewed the specific changes in this diff before the PR was opened. I have updated the description to use the repository template sections, completed the attestations with the validation scope and limitations, and clarified the AI-assistance note. |
MohammadHaroonAbuomar
left a comment
There was a problem hiding this comment.
Approving at 4eed115. In-memory store returns measurements sorted by timestamp regardless of insertion order; new test fails on main and passes here; ruff clean. Description uses the repository template with the attestations completed, and the author confirmed reviewing the diff before opening the PR. All 12 pull_request workflow runs on this head completed successfully. Commits are signed off.
MohammadHaroonAbuomar
left a comment
There was a problem hiding this comment.
Approving at 4eed115. In-memory store returns measurements sorted by timestamp regardless of insertion order; new test fails on main and passes here; ruff clean. Description uses the repository template with the attestations completed, and the author confirmed reviewing the diff before opening the PR. All 12 pull_request workflow runs on this head completed successfully. Commits are signed off.
Description
MeasurementStore promises ascending timestamp order, and SQLite honors it. The in-memory backend returns append order instead. Out-of-order arrivals therefore produce different query results depending on the backend, including a different final element for consumers such as CalibrationDeltaSLI.
Sort the filtered query result by timestamp under the existing lock. The store itself retains append order.
Validation
The regression fails before the fix and compares filtered out-of-order measurements against SQLite. Persistence tests: 39 passed. Full package run: 1,495 passed, 3 skipped, 1 known baseline failure (the separate Windows benchmark clock bug). Ruff reports the same two import-order findings and one SIM108 finding on unchanged main; no new lint findings.
All regressions were reproduced on origin/main
406ddd4dbefore the production change. Whitespace checks pass. The pre-existing Ruff findings are documented above. Changed-line spelling passes with the existing API identifierDeduplicatorallowed in the temporary check input.Scope: the existing Agent-SRE source tree, which remains exercised by repository CI. Combined validation of these six independent SRE fixes: 1,505 passed, 3 skipped on Windows/Python 3.12.
Type of Change
Package(s) Affected
Checklist
Attribution & Prior Art
Prior art / related projects: Uses the existing Agent-SRE implementation and standard library operations. No code was copied or adapted from an external project.
AI Assistance
I reviewed the specific changes in this diff before this PR was opened.
Codex assisted with implementation, regression tests, and local validation under my direction.
IP, Patents, and Licensing
Related Issues
Newly reproduced defect; the reproduction and regression coverage are described above.