Repository navigation
fix(agent-sre): calculate latency from windowed measurements - #4207
Conversation
Signed-off-by: Naveen Chatlapalli <[email protected]>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
🟡 Contributor Check: MEDIUM
Automated check by AGT Contributor Check. |
PR Review Summary
Verdict: AI review comments are untrusted advisory output. The summary reports workflow-generated completion status only, not model-authored pass/fail claims. |
|
Verified in code and locally: a 10,000 ms sample recorded over an hour ago was still reported on main; the percentile now reads from the windowed values and the shadow list is gone; three new tests fail on main. Sign-off is present and CI is approved and running. Before I approve, two process items that apply to all nine PRs in this batch: please use the repository template with its Checklist, Attribution, AI Assistance and IP sections, and tick the attestations in your own words. The AI note says Codex prepared and submitted the changes at your request; CONTRIBUTING asks that no PR be submitted by an agent without a human reviewing the specific changes, so one sentence confirming you reviewed this diff before it was opened settles it. Once that and the gated checks are green I will approve and merge. |
|
I reviewed the specific changes in this diff before the PR was opened. I have updated the description to use the repository template sections, completed the attestations with the validation scope and limitations, and clarified the AI-assistance note. |
MohammadHaroonAbuomar
left a comment
There was a problem hiding this comment.
Approving at 3cba702. Latency computed from the windowed measurement set instead of the full store; test reproduces the wrong value on main and passes here; ruff clean. Description uses the repository template with the attestations completed, and the author confirmed reviewing the diff before opening the PR. All 12 pull_request workflow runs on this head completed successfully. Commits are signed off.
MohammadHaroonAbuomar
left a comment
There was a problem hiding this comment.
Approving at 3cba702. Latency computed from the windowed measurement set instead of the full store; test reproduces the wrong value on main and passes here; ruff clean. Description uses the repository template with the attestations completed, and the author confirmed reviewing the diff before opening the PR. All 12 pull_request workflow runs on this head completed successfully. Commits are signed off.
Description
With a one-hour window, recording 10,000 ms and then 200 ms more than an hour later still reports 10,000 ms. Reconstructing the indicator over an existing SQLite store instead reports no value. Both happen because the percentile reads a separate process-local list instead of the measurement store.
Calculate the percentile from
values_in_window()and remove the redundant list. This uses the existing cutoff and persistence behavior without changing percentile indexing or SLO targets.Validation
Three regression cases fail before the fix: expired outlier, fully expired window, and SQLite restart. Indicator and persistence tests: 65 passed. Full package run: 1,497 passed, 3 skipped, 1 known baseline failure (the separate Windows benchmark clock bug).
All regressions were reproduced on origin/main
406ddd4dbefore the production change. Whitespace checks pass. Ruff passes on the changed files. Changed-line spelling passes with the existing API identifierDeduplicatorallowed in the temporary check input.Scope: the existing Agent-SRE source tree, which remains exercised by repository CI. Combined validation of these six independent SRE fixes: 1,505 passed, 3 skipped on Windows/Python 3.12.
Type of Change
Package(s) Affected
Checklist
Attribution & Prior Art
Prior art / related projects: Uses the existing Agent-SRE implementation and standard library operations. No code was copied or adapted from an external project.
AI Assistance
I reviewed the specific changes in this diff before this PR was opened.
Codex assisted with implementation, regression tests, and local validation under my direction.
IP, Patents, and Licensing
Related Issues
Newly reproduced defect; the reproduction and regression coverage are described above.