Fix description for percentage basis for text-decoration-inset in Firefox 154 release notes - #45261
Merged
pepelsbey merged 3 commits intoSep 14, 2026
Conversation
dletorey
approved these changes
Sep 14, 2026
Contributor
|
Preview URLs (2 pages) External URLs (2)URL:
URL:
|
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Corrects the description for percentage basis for
text-decoration-inset— fromfont-sizeto inline size — on the Firefox 154 release notes and experimental features pages.Motivation
Both pages state that percentages resolve against the
font-size. They don't. Per css-text-decor-4, percentages refer to the inline size of the decorating box, or of each individual box fragment, depending on the value ofbox-decoration-break.As written, a reader would expect
10%on 20px text to inset the decoration by 2px, when it actually resolves against the inline size of the box — a substantially different result.Additional details
This matches the Gecko implementation in bug 2044602, which resolves the percentage against the total inline size of the decorating box for
box-decoration-break: slice, or each fragment individually forclone.The wording follows the spec's
Percentages:definition, and the underlying CSSWG resolution is csswg-drafts#8403.The same sentence appears on both pages (added in #45027), so both are updated.
Related issues and pull requests
Fixes #45254
Relates to #44840