Repository navigation
Fix blank lines collapsing in paste view - #221
Merged
Merged
Conversation
Owner
|
What browser do you use and do you have a reproduction case? This seems fine on bin.bloerg.net: |
Contributor
Author
|
@matze you can test with https://paste.atlantisrp.it/thTK314CsXh |
Owner
|
Okay, seems I wasn't triggering it because I inserted via the form and you via the API. Thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the paste view, blank lines were not shown. The code shifted up relative to the line numbers, and the extra line numbers piled up at the bottom of the paste. The raw view was fine.
Each line of the paste is rendered as
<div id="LCn">…</div>. A blank line becomes an empty div, which the browser renders with zero height. The gutter divs have a fixed height of1.54em, so every blank line pushed the code one row further out of alignment with the line numbers.Fix
Give each code line
min-height: 1.54em, the same height as a gutter row. Blank lines now take up one row.min-heightinstead ofheightlets long lines keep wrapping when line wrapping is on.