Repository navigation
fix(phoenix): leave GenAI spans to Phoenix's own LLM/TOOL inference - #14
Merged
Merged
Conversation
The generic CHAIN fallback in transform/phoenix_kind also hit spans that carry GenAI semconv (gen_ai.operation.name), e.g. OpenClaw model calls. Phoenix infers LLM/TOOL from those itself, and with CHAIN forced they lost the chat-message view (system prompt, turns, tools). Exclude them from the generic GUARDRAIL/CHAIN rules. Claude-Session: https://claude.ai/code/session_016d5AJ1LjeunQ5sz5XEvxQQ Signed-off-by: mairp <[email protected]>
Contributor
Merge Queue Status
This pull request spent 46 seconds in the queue, including 31 seconds running CI. Required conditions to merge
|
7 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generic CHAIN fallback added in #9 also applied to spans that carry GenAI semantic conventions (
gen_ai.operation.name), such as OpenClaw model calls. Phoenix infers LLM/TOOL from those spans itself. With CHAIN forced on them, they lost Phoenix's chat-message view (system prompt, turns, tool definitions).This PR excludes them from the generic GUARDRAIL/CHAIN rules.
Verified live: an OpenClaw agent turn shows the model call as LLM again, with the Messages and Tools views, the run spans as AGENT, and context assembly as CHAIN. Router spans are unchanged (GUARDRAIL/CHAIN).
https://claude.ai/code/session_016d5AJ1LjeunQ5sz5XEvxQQ