Leave emoji out of the stats summary in plain mode - #2311

Thanks for looking into this. My first intuition is that the helper function is a bit of an antipattern here because it's quite "imperative."

The alternative would be to encapsulate the logic in the Stats structs themselves.

We can remove the Display impl on CompactHostStats/DetailedHostStats and instead have a method, which takes the OutputMode as an argument.

const STATS_EMOJI: &str = "📊";

impl CompactHostStats {
  fn format(mode: OutputMode) -> String {
    let mut buf = String::new();
    if *mode == OutputMode::Plain {
      buf.push(STATS_EMOJI);
    }
    // rest of the old logic
  }
}

Same for DetailedHostStats. wdyt?

Makes sense, done in 2677ce1. CompactHostStats and DetailedHostStats now have format(&self, mode: &OutputMode) instead of Display and push STATS_EMOJI only outside plain mode. It returns Result<String, fmt::Error> since the old body still writes with writeln!. The helper is gone.

The response stats structs already had the mode, so each one makes the same check inside its own fmt for now. I can move them to the format(mode) shape too if you want it the same everywhere.