Extract output functions

thomas-zahner · Dec 21, 2025 · Sep 5, 2025 · Sep 7, 2025 · Sep 7, 2025 · Sep 7, 2025
commit 3fdd99255563866aefdd3175718d778d066201c1
diff --git a/lychee-bin/src/formatters/stats/mod.rs b/lychee-bin/src/formatters/stats/mod.rs
@@ -13,17 +13,38 @@ pub(crate) use raw::Raw;
 use std::{
     collections::{HashMap, HashSet},
     fmt::Display,
+    fs,
+    io::{Write, stdout},
 };
 
-use crate::stats::ResponseStats;
-use anyhow::Result;
+use crate::{formatters::get_stats_formatter, options::Config, stats::ResponseStats};
+use anyhow::{Context, Result};
 use lychee_lib::InputSource;
 
 pub(crate) trait StatsFormatter {
     /// Format the stats of all responses and write them to stdout
     fn format(&self, stats: ResponseStats) -> Result<Option<String>>;
 }
 
+/// If configured to do so, output response statistics to stdout or the specified output file.
+pub(crate) fn output_response_statistics(stats: ResponseStats, config: &Config) -> Result<()> {
+    let is_empty = stats.is_empty();
+    let formatted_stats = get_stats_formatter(&config.format, &config.mode).format(stats)?;
+    if let Some(formatted_stats) = formatted_stats {
+        if let Some(output) = &config.output {
+            fs::write(output, formatted_stats).context("Cannot write status output to file")?;
+        } else {
+            if config.verbose.log_level() >= log::Level::Info && !is_empty {
+                // separate summary from the verbose list of links above with a newline
+                writeln!(stdout())?;
+            }
+            // we assume that the formatted stats don't have a final newline
+            writeln!(stdout(), "{formatted_stats}")?;
+        }
+    }
+    Ok(())
+}
+
 /// Convert a `ResponseStats` `HashMap` to a sorted Vec of key-value pairs
 /// The returned keys and values are both sorted in natural, case-insensitive order
 fn sort_stat_map<T>(stat_map: &HashMap<InputSource, HashSet<T>>) -> Vec<(&InputSource, Vec<&T>)>

diff --git a/lychee-bin/src/host_stats.rs b/lychee-bin/src/host_stats.rs
@@ -3,8 +3,8 @@ use lychee_lib::ratelimit::HostPool;
 
 use crate::{formatters::get_host_stats_formatter, options::Config};
 
-/// Display per-host statistics if requested
-pub(crate) fn display_per_host_statistics(host_pool: &HostPool, config: &Config) -> Result<()> {
+/// If configured to do so, output per-host statistics to stdout or the specified output file.
+pub(crate) fn output_per_host_statistics(host_pool: &HostPool, config: &Config) -> Result<()> {
     if !config.host_stats {
         return Ok(());
     }

diff --git a/lychee-bin/src/main.rs b/lychee-bin/src/main.rs
@@ -59,13 +59,13 @@
 #![deny(missing_docs)]
 
 use std::fs::{self, File};
-use std::io::{self, BufRead, BufReader, ErrorKind, Write};
+use std::io::{self, BufRead, BufReader, ErrorKind};
 use std::path::PathBuf;
 
 use anyhow::{Context, Error, Result, bail};
 use clap::{Parser, crate_version};
 use commands::{CommandParams, generate};
-use formatters::{get_stats_formatter, log::init_logging};
+use formatters::log::init_logging;
 use http::HeaderMap;
 use log::{error, info, warn};
 
@@ -93,11 +93,13 @@ mod stats;
 mod time;
 mod verbosity;
 
+use crate::formatters::stats::output_response_statistics;
+use crate::stats::ResponseStats;
 use crate::{
     cache::{Cache, StoreExt},
-    formatters::{duration::Duration, stats::StatsFormatter},
+    formatters::duration::Duration,
     generate::generate,
-    host_stats::display_per_host_statistics,
+    host_stats::output_per_host_statistics,
     options::{Config, LYCHEE_CACHE_FILE, LYCHEE_IGNORE_FILE, LycheeOptions},
 };
 
@@ -381,7 +383,6 @@ async fn run(opts: &LycheeOptions) -> Result<i32> {
     })?;
 
     let client = client::create(&opts.config, cookie_jar.as_deref())?;
-
     let params = CommandParams {
         client,
         cache,
@@ -393,41 +394,9 @@ async fn run(opts: &LycheeOptions) -> Result<i32> {
         commands::dump(params).await?
     } else {
         let (stats, cache, exit_code, host_pool) = commands::check(params).await?;
-
-        let github_issues = stats
-            .error_map
-            .values()
-            .flatten()
-            .any(|body| body.uri.domain() == Some("github.com"));
-
-        let stats_formatter: Box<dyn StatsFormatter> =
-            get_stats_formatter(&opts.config.format, &opts.config.mode);
-
-        let is_empty = stats.is_empty();
-        let formatted_stats = stats_formatter.format(stats)?;
-
-        if let Some(formatted_stats) = formatted_stats {
-            if let Some(output) = &opts.config.output {
-                fs::write(output, formatted_stats).context("Cannot write status output to file")?;
-            } else {
-                if opts.config.verbose.log_level() >= log::Level::Info && !is_empty {
-                    // separate summary from the verbose list of links above
-                    // with a newline
-                    writeln!(io::stdout())?;
-                }
-                // we assume that the formatted stats don't have a final newline
-                writeln!(io::stdout(), "{formatted_stats}")?;
-            }
-        }
-
-        // Display per-host statistics if requested
-        display_per_host_statistics(host_pool.as_ref(), &opts.config)?;
-
-        if github_issues && opts.config.github_token.is_none() {
-            warn!(
-                "There were issues with GitHub URLs. You could try setting a GitHub token and running lychee again.",
-            );
-        }
+        github_warning(&stats, &opts.config);
+        output_response_statistics(stats, &opts.config)?;
+        output_per_host_statistics(&host_pool, &opts.config)?;
 
         if opts.config.cache {
             cache.store(LYCHEE_CACHE_FILE)?;
@@ -443,3 +412,17 @@ async fn run(opts: &LycheeOptions) -> Result<i32> {
 
     Ok(exit_code as i32)
 }
+
+/// Display user-friendly message if there were any issues with GitHub URLs
+fn github_warning(stats: &ResponseStats, config: &Config) {
+    let github_errors = stats
+        .error_map
+        .values()
+        .flatten()
+        .any(|body| body.uri.domain() == Some("github.com"));
+    if github_errors && config.github_token.is_none() {
+        warn!(
+            "There were issues with GitHub URLs. You could try setting a GitHub token and running lychee again.",
+        );
+    }
+}