Skip to content

Commit fcbe4e1

Browse files
committed
Tests: remove possible race condition
Simplify JP2 quality size check
1 parent 9280742 commit fcbe4e1

3 files changed

Lines changed: 10 additions & 14 deletions

File tree

.cirrus.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ freebsd_instance:
22
image_family: freebsd-14-0-snap
33

44
task:
5-
name: FreeBSD 13.0
5+
name: FreeBSD
66
env:
77
IGNORE_OSVERSION: yes
88
skip_notifications: true

test/unit/jp2.js

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -48,15 +48,8 @@ describe('JP2 output', () => {
4848
.resize(320, 240)
4949
.toBuffer(function (err, buffer80) {
5050
if (err) throw err;
51-
sharp(fixtures.inputJp2)
52-
.resize(320, 240)
53-
.jp2({ quality: 90 })
54-
.toBuffer(function (err, buffer90) {
55-
if (err) throw err;
56-
assert(buffer70.length < buffer80.length);
57-
assert(buffer80.length < buffer90.length);
58-
done();
59-
});
51+
assert(buffer70.length < buffer80.length);
52+
done();
6053
});
6154
});
6255
});

test/unit/util.js

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -68,10 +68,13 @@ describe('Utilities', function () {
6868
});
6969

7070
describe('Counters', function () {
71-
it('Have zero value at rest', function () {
72-
const counters = sharp.counters();
73-
assert.strictEqual(0, counters.queue);
74-
assert.strictEqual(0, counters.process);
71+
it('Have zero value at rest', (done) => {
72+
queueMicrotask(() => {
73+
const counters = sharp.counters();
74+
assert.strictEqual(0, counters.queue);
75+
assert.strictEqual(0, counters.process);
76+
done();
77+
});
7578
});
7679
});
7780

0 commit comments

Comments
 (0)