Repository navigation
Conversation
CoralGarden52
requested review from
JohnJyong,
QuantumGhost and
laipz8200
as code owners
September 8, 2026 13:28
Contributor
Pyrefly Type Coverage
|
fatelei
approved these changes
Sep 9, 2026
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UploadFilerows only after confirming that no bindings still reference them, preserving shared attachmentsThis follows the attachment lifecycle and orphan-check behavior established by #41400 while keeping this bug fix scoped to the re-index path.
Fixes #41994
Screenshots
Not applicable. This is a backend cleanup task fix.
Testing
api/.venv/bin/pytest -q api/tests/unit_tests/tasks/test_document_indexing_update_task.py(16 passed)api/.venv/bin/pytest -q api/tests/unit_tests/tasks/test_document_indexing_update_task.py api/tests/unit_tests/tasks/test_segment_index_cleanup_tasks.py api/tests/unit_tests/tasks/test_batch_clean_document_task.py api/tests/unit_tests/tasks/test_clean_document_task.py(28 passed)api/.venv/bin/ruff format --check api/tasks/document_indexing_update_task.py api/tests/unit_tests/tasks/test_document_indexing_update_task.pyapi/.venv/bin/ruff check api/tasks/document_indexing_update_task.py api/tests/unit_tests/tasks/test_document_indexing_update_task.pyapi/.venv/bin/pyrefly check api/tasks/document_indexing_update_task.pyChecklist
make lint && make type-check(backend). Targeted Ruff and Pyrefly checks passed; full Mypy is blocked locally by missing optional provider packages.From Codex