Skip to content

fix(test): extend timeout for ripgrep tests that download the rg binary (LAC-2693) #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lacymorrow wants to merge 1 commit into from
Closed

fix(test): extend timeout for ripgrep tests that download the rg binary (LAC-2693) #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/core/test/filesystem/search.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ import { testEffect } from "../lib/effect"

const it = testEffect(LayerNode.compile(Ripgrep.node))

// first Ripgrep use may download and extract the rg binary, which exceeds the
// default 5s test timeout on Windows CI runners (PowerShell Expand-Archive)
const RG_DOWNLOAD = { timeout: 120_000 }

const withTmp = <A, E, R>(f: (directory: AbsolutePath) => Effect.Effect<A, E, R>) =>
Effect.acquireRelease(
Effect.promise(() => tmpdir()),
Expand All @@ -26,6 +30,7 @@ describe("Ripgrep", () => {
expect(result.map((item) => item.path)).toEqual([RelativePath.make("src/match.ts")])
}),
),
RG_DOWNLOAD,
)

it.live("greps files with include filtering", () =>
Expand All @@ -40,5 +45,6 @@ describe("Ripgrep", () => {
expect(result[0]?.submatches[0]?.text).toBe("needle")
}),
),
RG_DOWNLOAD,
)
})
6 changes: 6 additions & 0 deletions packages/core/test/ripgrep.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ import { testEffect } from "./lib/effect"

const it = testEffect(LayerNode.compile(Ripgrep.node))

// first Ripgrep use may download and extract the rg binary, which exceeds the
// default 5s test timeout on Windows CI runners (PowerShell Expand-Archive)
const RG_DOWNLOAD = { timeout: 120_000 }

describe("Ripgrep", () => {
it.live("keeps ignored files out of catch-all find results", () =>
Effect.acquireUseRelease(
Expand All @@ -29,6 +33,7 @@ describe("Ripgrep", () => {
}),
(tmp) => Effect.promise(() => tmp[Symbol.asyncDispose]()),
),
RG_DOWNLOAD,
)

it.live("never includes git metadata", () =>
Expand Down Expand Up @@ -61,5 +66,6 @@ describe("Ripgrep", () => {
}),
(tmp) => Effect.promise(() => tmp[Symbol.asyncDispose]()),
),
RG_DOWNLOAD,
)
})
Loading