Skip to content

Commit f21afab

Browse files
gnufiedk8s-publishing-bot
authored andcommitted
Add validation for camelcase in reason field
Update test/declarative_validation/core/pod/declarative_validation_test.go Co-authored-by: Eddie <[email protected]> Kubernetes-commit: c362ec8eb6518a2fad85848d4d1281380fd87568
1 parent d7ad413 commit f21afab

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

pkg/apis/meta/v1/validation/validation.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -367,7 +367,7 @@ func ValidateCondition(condition metav1.Condition, fldPath *field.Path) field.Er
367367
if len(condition.Reason) == 0 {
368368
allErrs = append(allErrs, field.Required(fldPath.Child("reason"), "").MarkCoveredByDeclarative())
369369
} else {
370-
for _, currErr := range isValidConditionReason(condition.Reason) {
370+
for _, currErr := range IsValidConditionReason(condition.Reason) {
371371
allErrs = append(allErrs, field.Invalid(fldPath.Child("reason"), condition.Reason, currErr))
372372
}
373373
if len(condition.Reason) > maxReasonLen {
@@ -387,8 +387,9 @@ const conditionReasonErrMsg string = "a condition reason must start with alphabe
387387

388388
var conditionReasonRegexp = regexp.MustCompile("^" + conditionReasonFmt + "$")
389389

390-
// isValidConditionReason tests for a string that conforms to rules for condition reasons. This checks the format, but not the length.
391-
func isValidConditionReason(value string) []string {
390+
// IsValidConditionReason tests for a string that conforms to rules for condition
391+
// reasons. This checks the format, but not the length.
392+
func IsValidConditionReason(value string) []string {
392393
if !conditionReasonRegexp.MatchString(value) {
393394
return []string{validation.RegexError(conditionReasonErrMsg, conditionReasonFmt, "my_name", "MY_NAME", "MyName", "ReasonA,ReasonB", "ReasonA:ReasonB")}
394395
}

0 commit comments

Comments
 (0)